Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small bug in prim logger #155

Closed
vioSpark opened this issue Aug 2, 2022 · 1 comment · Fixed by #161
Closed

small bug in prim logger #155

vioSpark opened this issue Aug 2, 2022 · 1 comment · Fixed by #161
Assignees
@quaquel
Labels
bug
Milestone
2.2.1

Comments

@vioSpark
Copy link

vioSpark commented Aug 2, 2022

I'm not yet sure if this is really a bug, or I made somewhere a mistake, but in the below line should be
_logger.debug("pasting " + str(u))
instead of
_logger.debug("pasting " + u)

source code here

The current implementation throws
TypeError: can only concatenate str (not "numpy.int64") to str

I'll come back if I find out more details
@quaquel quaquel added the bug label Aug 31, 2022
@EwoutH EwoutH added this to the 2.3.0 milestone Aug 31, 2022
quaquel added a commit that referenced this issue Sep 1, 2022
@quaquel
switch to using format string in prim logging
95b95e2 
fixes #155
@quaquel quaquel mentioned this issue Sep 1, 2022
Merged
@quaquel
Copy link
Owner

quaquel commented Sep 1, 2022

fixed with #161

@quaquel quaquel closed this as completed Sep 1, 2022
@EwoutH EwoutH mentioned this issue Oct 5, 2022
Merged
EwoutH pushed a commit that referenced this issue Oct 6, 2022
@quaquel @EwoutH
Switch to using format string in prim logging (#161)
80cc855 
The main purpose is to fix #155 but I used this as an excuse to modify other logging message to switch to using format strings as well
@EwoutH EwoutH modified the milestones: 2.3.0, 2.2.1 Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quaquel quaquel

Labels
bug
Projects
None yet
Milestone
2.2.1
Development

Successfully merging a pull request may close this issue.

switch to using format string in prim logging quaquel/EMAworkbench
3 participants
@quaquel @EwoutH @vioSpark