switch to using format string in prim logging #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwoutH
reviewed
Sep 1, 2022
ema_workbench/analysis/prim.py
Outdated
Comment on lines
1048
to
1050
| ( | ||
| "{} dropped from analysis " "because only a single category" | ||
| ).format(column) | ||
| f"{column} dropped from analysis " "because only a single category" | ||
| ) |
There was a problem hiding this comment.
I think both the break in stings " " could be removed, as well as the extra set of parentheses.
ema_workbench/analysis/prim.py
Outdated
Comment on lines
1165
to
1168
| ( | ||
| "box does not meet threshold criteria, " | ||
| "value is {}, returning dump box" | ||
| ).format(box.mean) | ||
| f"value is {box.mean}, returning dump box" | ||
| ) |
There was a problem hiding this comment.
Does this also fit on a single line? If yes, same as above
There was a problem hiding this comment.
some lines could indeed be reduced, see the latest commit. I already ran black on the file as well.
EwoutH
pushed a commit
that referenced
this pull request
Oct 6, 2022
The main purpose is to fix #155 but I used this as an excuse to modify other logging message to switch to using format strings as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose is to fix #155 but I used this as an excuse to modify other logging message to switch to using format strings as well