Remove template-generated index.htmls #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
adopt-dynamic-quickstarts
branch
from
72e83e7 to
3610792
Compare
phillip-kruger
approved these changes
Oct 7, 2024
|
Thanks! |
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #1457.
New versions of Quarkus automatically generate a landing page, so we do not need an index.html anymore. Since code is a liability, we should reduce it where we can.
Some quickstarts have an index.html with contents that was hand-crafted, so I left those. The way I distinguished between the two was looking for the text
Congratulations, you have created a new Quarkus application. This does mean we lose some hand-crafted content on some of theindex.htmltitles, but I think we can live with that?