Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC Auth Quickstart failures #1463

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

gtroitsk
Copy link
Contributor

Closes issue #1461

CodeFlowTest fails after deleting index.html in #1459. Test needs to provide own html page

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@holly-cummins
Copy link
Contributor

Thanks! I wonder why the CI was green for my change?

@gtroitsk
Copy link
Contributor Author

Thanks! I wonder why the CI was green for my change?

As I can see, CI wasn't triggered in your PR

This comment has been minimized.

@holly-cummins
Copy link
Contributor

Thanks! I wonder why the CI was green for my change?

As I can see, CI wasn't triggered in your PR

You're right, https://github.com/quarkusio/quarkus-quickstarts/pull/1459/checks is totally empty. I've looked in the PR workflow definition and can't see anything that would skip the CI for that kind of change.

However, looking at the history of the PR, I see that at some point I clicked the wrong thing, and raised the PR against main, not development. I fixed that, but perhaps by then the CI had been bypassed. I'll raise an issue to discuss possible solutions (and if we should bother fixing): #1465

@gtroitsk
Copy link
Contributor Author

Failure in vertx-quickstart is unrelated and will be fixed by #1462

@rsvoboda
Copy link
Member

@gtroitsk can you please rebase the PR, I merged #1462

@gtroitsk
Copy link
Contributor Author

@gtroitsk can you please rebase the PR, I merged #1462

Rebased. Can you please retrigger CI, I don't have rights

Copy link

quarkus-bot bot commented Oct 21, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit b5563b3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit edc470a into quarkusio:development Oct 21, 2024
2 checks passed
@gtroitsk gtroitsk deleted the fix-oidc-auth-test branch October 21, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants