Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and replace external API fruityvice.com by swapi.dev #1462

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jcarranzan
Copy link
Contributor

This PR will close this issue:
#1460
The API fruityvice.com is already not available so I've moved to a new one swapi.dev as it's commented in the issue above.

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@rsvoboda
Copy link
Member

@jcarranzan you have checked targets the development branch but the PR is for main ;) Please target development branch

@jcarranzan jcarranzan changed the base branch from main to development October 14, 2024 11:09
@cescoffier
Copy link
Member

We also need to update the https://quarkus.io/guides/vertx-reference guide (I'm on it).

@cescoffier
Copy link
Member

ah ah, no, no need to update the guide, it's written in a way it does not use the URL.

Copy link

quarkus-bot bot commented Oct 14, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit e54882f.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing: security-openid-connect-web-authentication-quickstart 

📦 security-openid-connect-web-authentication-quickstart

org.acme.security.openid.connect.web.authentication.CodeFlowTest.testCodeFlowNoConsent line 41 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:8081/index.html
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:595)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2277)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.doProcessPostponedActions(JavaScriptEngine.java:914)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.processPostponedActions(JavaScriptEngine.java:1002)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1047)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:989)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:897)

org.acme.security.openid.connect.web.authentication.CodeFlowTest.testTokenInjection line 128 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:8081/index.html
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:595)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2277)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.doProcessPostponedActions(JavaScriptEngine.java:914)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.processPostponedActions(JavaScriptEngine.java:1002)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1047)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:989)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:897)

org.acme.security.openid.connect.web.authentication.CodeFlowTest.testTokenTimeoutLogout line 71 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:8081/index.html
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:595)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2277)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.doProcessPostponedActions(JavaScriptEngine.java:914)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.processPostponedActions(JavaScriptEngine.java:1002)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1047)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:989)
	at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:897)

@rsvoboda
Copy link
Member

@sberyozkin there are some unexpected security-openid-connect-web-authentication-quickstart failures, anything suspicious?

@gtroitsk gtroitsk mentioned this pull request Oct 17, 2024
10 tasks
@rsvoboda
Copy link
Member

I will merge this, approved and failures are unrelated (should be fixed in #1463)

@rsvoboda rsvoboda merged commit f953bd4 into quarkusio:development Oct 21, 2024
2 of 3 checks passed
@fedinskiy
Copy link
Contributor

@rsvoboda can we have this backported to 3.15 branch?

@rsvoboda
Copy link
Member

@jcarranzan please create PR targetting 3.15 branch, there are no group backports on QS repo like in Quarkus main repo.

jcarranzan pushed a commit to jcarranzan/quarkus-quickstarts that referenced this pull request Oct 21, 2024
Fix and replace external API fruityvice.com by swapi.dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants