-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and replace external API fruityvice.com by swapi.dev #1462
Conversation
@jcarranzan you have checked |
dc629dc
to
e54882f
Compare
We also need to update the https://quarkus.io/guides/vertx-reference guide (I'm on it). |
ah ah, no, no need to update the guide, it's written in a way it does not use the URL. |
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs |
---|---|---|---|---|---|
✖ | Build - JDK 17 | Build with Maven |
Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
Failures
⚙️ Build - JDK 17 #
- Failing: security-openid-connect-web-authentication-quickstart
📦 security-openid-connect-web-authentication-quickstart
✖ org.acme.security.openid.connect.web.authentication.CodeFlowTest.testCodeFlowNoConsent
line 41
- More details - Source on GitHub
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:8081/index.html
at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:595)
at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2277)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.doProcessPostponedActions(JavaScriptEngine.java:914)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.processPostponedActions(JavaScriptEngine.java:1002)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1047)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:989)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:897)
✖ org.acme.security.openid.connect.web.authentication.CodeFlowTest.testTokenInjection
line 128
- More details - Source on GitHub
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:8081/index.html
at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:595)
at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2277)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.doProcessPostponedActions(JavaScriptEngine.java:914)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.processPostponedActions(JavaScriptEngine.java:1002)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1047)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:989)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:897)
✖ org.acme.security.openid.connect.web.authentication.CodeFlowTest.testTokenTimeoutLogout
line 71
- More details - Source on GitHub
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not Found for http://localhost:8081/index.html
at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:595)
at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2277)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.doProcessPostponedActions(JavaScriptEngine.java:914)
at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.processPostponedActions(JavaScriptEngine.java:1002)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:1047)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:989)
at com.gargoylesoftware.htmlunit.html.DomElement.click(DomElement.java:897)
@sberyozkin there are some unexpected security-openid-connect-web-authentication-quickstart failures, anything suspicious? |
I will merge this, approved and failures are unrelated (should be fixed in #1463) |
@rsvoboda can we have this backported to 3.15 branch? |
@jcarranzan please create PR targetting 3.15 branch, there are no group backports on QS repo like in Quarkus main repo. |
Fix and replace external API fruityvice.com by swapi.dev
This PR will close this issue:
#1460
The API fruityvice.com is already not available so I've moved to a new one swapi.dev as it's commented in the issue above.
Check list:
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md