Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change security-openid-connect and security-openid-connect-web-authentication to dev services #928

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Change security-openid-connect and security-openid-connect-web-authentication to dev services #928

merged 1 commit into from
Sep 7, 2021

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Aug 26, 2021

This PR uses #925's idea and adds a newly introduced KeycloakTestClient for security-openid-connect-quickstart and similarly for security-openid-connect-web-authentication-quickstart (where KeycloakTestClient is not needed).
The OIDC multi tenant and keycloak authorization still use the test factories

@sberyozkin
Copy link
Member Author

And next will be the docs update :-)

@sberyozkin sberyozkin changed the title Change OIDC quickstart to dev services Change security-openid-connect and security-openid-connect-web-authentication to dev services Aug 26, 2021
@sberyozkin
Copy link
Member Author

sberyozkin commented Aug 27, 2021

@stuartwdouglas I'd like to change a package name for KeycloakTestClient from io.quarkus.test.keycloak.server to io.quarkus.test.keycloak.client, going to open a PR in Quarkus: done

@sberyozkin
Copy link
Member Author

@stuartwdouglas I've restarted the builds and the OIDC tests in both quickstarts have passed:

https://github.com/quarkusio/quarkus-quickstarts/runs/3494459332?check_suite_focus=true

Quite a few other quickstarts fail - it is not related

@sberyozkin sberyozkin merged commit d4eed2b into quarkusio:development Sep 7, 2021
@sberyozkin sberyozkin deleted the security-openid-connect-devservices branch September 7, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants