-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to test OIDC with DevServices and minor updates to quarkus-test-keycloak-server #19734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @gastaldi :-), I'll wait till Monday in case Stuart will have something to comment and merge then |
3e72172
to
c2a3ab0
Compare
Oops, forgot Stuart added |
28e5a49
to
d02f211
Compare
@gastaldi I've followed up with some updates to the |
d02f211
to
a8d43fe
Compare
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-dev-services.adoc
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 01e5ba8
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 13ce26f
|
…us-test-keycloak-server
679d767
to
392cc6f
Compare
@gsmet Thanks for the review |
@stuartwdouglas I'll wait until you are back online before I merge, in case you'd like to comment on something. We can always improve these docs going forward as well, thanks |
@gsmet Your suggested changes have been applied, thanks; will be merging soon
Hi All, let me merge now - I'll be following up with further updates shortly anyway |
This PR:
service
andweb-app
applications withDev Services For Keycloak
KeycloakTestResourceLifecycleManager
to disableDev Services For Keycloak
as proposed by StuartKeycloakTestClient
to have aclient
(instead ofserver
) sub-packageSee also: quarkusio/quarkus-quickstarts#928