Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to test OIDC with DevServices and minor updates to quarkus-test-keycloak-server #19734

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Aug 27, 2021

This PR:

  • documents how to test OIDC service and web-app applications with Dev Services For Keycloak
  • updates KeycloakTestResourceLifecycleManager to disable Dev Services For Keycloak as proposed by Stuart
  • changes KeycloakTestClient to have a client (instead of server) sub-package

See also: quarkusio/quarkus-quickstarts#928

@sberyozkin sberyozkin changed the title Documenting how to test OIDC with DevServices and minor updates to quarkus-test-keycloak-server Document how to test OIDC with DevServices and minor updates to quarkus-test-keycloak-server Aug 27, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sberyozkin
Copy link
Member Author

Thanks @gastaldi :-), I'll wait till Monday in case Stuart will have something to comment and merge then

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 27, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 3e72172

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@sberyozkin
Copy link
Member Author

Oops, forgot Stuart added KeycloakTestClient to the OIDC token propagation test

@sberyozkin sberyozkin force-pushed the devservices_doc_updates branch 2 times, most recently from 28e5a49 to d02f211 Compare August 27, 2021 18:50
@sberyozkin
Copy link
Member Author

@gastaldi I've followed up with some updates to the Dev Services for Keycloak doc - added a note about sharing the containers, linked to the newly added sections about the integration testing with DevServices, clarified the note about registering the redirect URI as suggested by @paulrobinson

gsmet
gsmet previously requested changes Aug 30, 2021
docs/src/main/asciidoc/security-openid-connect.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/security-openid-connect.adoc Outdated Show resolved Hide resolved
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 01e5ba8

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build ⚠️ Check → Logs Raw logs
Attach pull request number ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 30, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 13ce26f

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build ⚠️ Check → Logs Raw logs
Attach pull request number ⚠️ Check → Logs Raw logs
CI Sanity Check ⚠️ Check → Logs Raw logs

@sberyozkin
Copy link
Member Author

@gsmet Thanks for the review

@sberyozkin
Copy link
Member Author

@stuartwdouglas I'll wait until you are back online before I merge, in case you'd like to comment on something. We can always improve these docs going forward as well, thanks

@sberyozkin sberyozkin dismissed gsmet’s stale review August 31, 2021 08:47

@gsmet Your suggested changes have been applied, thanks; will be merging soon

@sberyozkin
Copy link
Member Author

Hi All, let me merge now - I'll be following up with further updates shortly anyway

@sberyozkin sberyozkin merged commit 2f02e97 into quarkusio:main Aug 31, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 31, 2021
@sberyozkin sberyozkin deleted the devservices_doc_updates branch August 31, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants