Native Build on Windows has incorrect resource slashes

[melloware]

Describe the bug

original conversation: #13275

When building a Native image on Windows the quarkus-native-resources.txt has mixed slashes which then causes the resources not to be found.

Windows (Incorrect):
META-INF/resources/resources\showcase\images\layouts\manhattan.jpg

Linux (Correct):
META-INF/resources/resources/showcase/images/layouts/manhattan.jpg

Expected behavior

No matter the slashes the resource should be added .

Actual behavior

Resource gets a "FileNotFoundException" at runtime.

How to Reproduce?

1. On Windows git clone https://github.com/quarkiverse/quarkus-primefaces
2. Run mvn -B install -Dnative -Dquarkus.native.container-build -Dnative.surefire.skip

You will see the slashes are wrong.

Output of uname -a or ver

Microsoft Windows [Version 10.0.22621.1265]

Output of java -version

OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)

GraalVM version (if different from Java)

Mandrel 22.3

Quarkus version or git rev

2.16.3

Build tool (ie. output of mvnw --version or gradlew --version)

Maven 3.8.6

Additional information

No response

[quarkus-bot]

/cc @Karm (mandrel), @galderz (mandrel), @zakkak (mandrel)

[zakkak]

Note that #31185 is going to remove the use of quarkus-native-resources.txt. But the issue will probably remain as the paths are added to resource-config.json instead.

[Sanne]

Let's keep in mind that these are resource paths - not filesystem paths. Does it actually break something on Windows?

[melloware]

Let me double check I was getting "java.io.FileNotFoundException" when building in Windows but not in Linux so maybe the issue is somewhere else I just saw the slashes as incorrect here and thought it looks weird.

[melloware]

I originally ran into this where my Integration Tests won't run on Windows but run fine on Linux: #13275 (comment)

[melloware]

I have confirmed it does not work on Windows I can see the files are in the proper path in the executable but is getting FileNotFoundExceptions.

[Karm]

I have it reproduced on my Win10 system using Podman for Windows:

[INFO] Running io.quarkiverse.primefaces.it.PrimeFacesResourceIT
Executing "C:\tmp\quarkus-primefaces\quarkus-primefaces\integration-tests\target/quarkus-primefaces-integration-tests-2.12.1-SNAPSHOT-runner -Dquarkus.http.port=8081 -Dquarkus.http.ssl-port=8444 -Dtest.url=http://localhost:8081 -Dquarkus.log.file.path=C:\tmp\quarkus-primefaces\quarkus-primefaces\integration-tests\target\quarkus.log -Dquarkus.log.file.enable=true"
[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 11.219 s <<< FAILURE! - in io.quarkiverse.primefaces.it.PrimeFacesResourceIT
[ERROR] shouldAllowTemplate  Time elapsed: 0.062 s  <<< ERROR!
java.lang.RuntimeException: java.io.IOException: Cannot run program "C:\tmp\quarkus-primefaces\quarkus-primefaces\integration-tests\target/quarkus-primefaces-integration-tests-2.12.1-SNAPSHOT-runner": CreateProcess error=193, %1 is not a valid Win32 application
Caused by: java.io.IOException: Cannot run program "C:\tmp\quarkus-primefaces\quarkus-primefaces\integration-tests\target/quarkus-primefaces-integration-tests-2.12.1-SNAPSHOT-runner": CreateProcess error=193, %1 is not a valid Win32 application
Caused by: java.io.IOException: CreateProcess error=193, %1 is not a valid Win32 application

[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   PrimeFacesResourceIT.shouldAllowTemplate » Runtime java.io.IOException: Cannot...
[INFO]
[ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 1
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:2.22.2:verify (default) @ quarkus-primefaces-integration-tests ---

[Karm]

Well, this is a misunderstanding. The application is in fact an elf Linux amd64 binary, because it was built in the Linux builder container.

The fix for the test is to run it in a container too....

[Karm]

I'll refactor the PrimeFaces test run with jib extension and see how it goes.

[Karm]

I almost got it, currently hinging on Docker vs. JVM process locking the log file :)

Caused by: java.nio.file.FileSystemException: target\quarkus.log: The process cannot access the file because it is being used by another process

I'll open a PR to quarkus-prime faces when I get it unstuck.

[Karm]

@melloware

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Quarkus PrimeFaces Ecosystem 2.12.1-SNAPSHOT:
[INFO]
[INFO] Quarkus PrimeFaces Ecosystem ....................... SUCCESS [  2.672 s]
[INFO] Quarkus PrimeFaces - Parent ........................ SUCCESS [  0.250 s]
[INFO] Quarkus PrimeFaces - Runtime ....................... SUCCESS [ 12.406 s]
[INFO] Quarkus PrimeFaces - Deployment .................... SUCCESS [ 33.422 s]
[INFO] Quarkus PrimeFaces - Integration Tests ............. SUCCESS [09:58 min]
[INFO] Quarkus PrimeFaces Extensions - Parent ............. SUCCESS [  0.094 s]
[INFO] Quarkus PrimeFaces Extensions - Runtime ............ SUCCESS [  5.281 s]
[INFO] Quarkus PrimeFaces Extensions - Deployment ......... SUCCESS [ 40.594 s]
[INFO] Quarkus PrimeFaces Extensions - Integration Tests .. SUCCESS [11:18 min]
[INFO] Quarkus PrimeFaces - Documentation ................. SUCCESS [ 33.406 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23:25 min
[INFO] Finished at: 2023-02-26T12:27:25-08:00
[INFO] ------------------------------------------------------------------------

So, I've got it working, Podman for Windows on a Windows 10 system.
The good news is that it works, the bad news is that there are fixes needed in Quarkus code to correctly drive the Podman test in container on Windows.

I will try with Docker Desktop too 👍

[melloware]

Thank you for working on this!

[Karm]

@melloware Here is a PR to Quarkus PrimeFaces: quarkiverse/quarkus-primefaces#12
PR to Quarkus is pending, I'd like to add a specific test first...

I suggest migrating to Jakarta and Quarkus 3 too. Otherwise the Primefaces integration would be stuck with Q 2.16.x...

[melloware]

Yeah My plan was to get a JSF app fully native with PF on the 2.x branch. Then migrate to the 3.x Quarkus branch! Thanks for all your hard work on this!