-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus REST: various issues with lastModified
dates
#41110
Comments
/cc @stuartwdouglas (resteasy-reactive) |
Apparently, the problem is not
|
- Round Dates to second precision when comparing them - Lookup header delegate for Date and subtypes Fixes quarkusio#41110
- Round Dates to second precision when comparing them - Lookup header delegate for Date and subtypes Fixes quarkusio#41110 (cherry picked from commit 07b3f94)
- Round Dates to second precision when comparing them - Lookup header delegate for Date and subtypes Fixes quarkusio#41110 (cherry picked from commit 07b3f94)
- Round Dates to second precision when comparing them - Lookup header delegate for Date and subtypes Fixes quarkusio#41110
- Round Dates to second precision when comparing them - Lookup header delegate for Date and subtypes Fixes quarkusio#41110 (cherry picked from commit 07b3f94)
- Round Dates to second precision when comparing them - Lookup header delegate for Date and subtypes Fixes quarkusio#41110
Describe the bug
ResponseBuilder.lastModified
will use whatever user-configuredParamConverter
forDate
, which is wrong, because HTTP date headers must be formatted in a special way, otherwise we will fail parsing themRequest.evaluatePreconditions(Date)
is very likely to never work, becauseDate
is millisecond-precision, whereas HTTP headers are second-precision, so there's 999/1000 chances that the date we're passed will be later than the (truncated) header, unless the user applies this truncation beforehand (and knows about it). We should truncate it ourselves, because we only operate on second-precision due to HTTP limitations.Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: