Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus REST: Fix two Date issues regarding preconditions #41123

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Jun 11, 2024

  • Round Dates to second precision when comparing them
  • Lookup header delegate for Date and subtypes

Fixes #41110

- Round Dates to second precision when comparing them
- Lookup header delegate for Date and subtypes

Fixes quarkusio#41110
Copy link

quarkus-bot bot commented Jun 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 07b3f94.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testFruits - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <6> but was: <5> within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.it.kafka.KafkaConnectorTest.testFruits(KafkaConnectorTest.java:63)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@geoand geoand merged commit 27d42a8 into quarkusio:main Jun 12, 2024
46 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 12, 2024
@FroMage FroMage deleted the 41110 branch June 12, 2024 12:31
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.0 Jun 14, 2024
@gsmet gsmet modified the milestones: 3.12.0, 3.11.3 Jun 18, 2024
@gsmet gsmet modified the milestones: 3.11.3, 3.8.6 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus REST: various issues with lastModified dates
4 participants