-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to parse days and milliseconds with config DurationConverter #32929
Add possibility to parse days and milliseconds with config DurationConverter #32929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's an interesting addition but let's wait for @radcortez 's opinion before merging.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the new feature, but the test failures are related.
0f89296
to
50862d2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
50862d2
to
f7b6778
Compare
rebased, just in case. |
@gsmet do you think it is possible to have that in 3.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, thanks @manofthepeace . Can we update the duration format note doc: https://github.com/quarkusio/quarkus/blob/f7b67786ab8d51c499227bcceee523eb96298e08/docs/src/main/asciidoc/_includes/duration-format-note.adoc? Thanks
9bd6b69
to
fee131f
Compare
@machi1990 thanks for the review. Updated the duration format note. |
f414c6f
to
e774246
Compare
e774246
to
a6f898b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@machi1990 went though the log but have trouble seeing anything related, would you know better? |
I've re-run the failed job again to rule out any consistent failures. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
🙈 The PR is closed and the preview is expired. |
This adds the possibility to convert durations in milliseconds like
25ms
or days7d
. Made theSTART_WITH_DIGITS
case a bit more solid by allowing only valid units, case insensitive.