Updates to Infinispan 14.0.19.Final #36445

karesti · 2023-10-12T12:51:59Z

latest stable release

Sanne · 2023-10-13T08:32:43Z

Hi @karesti - there are some failures, could you have a look? Thanks!

gsmet · 2023-10-13T09:37:42Z

You can ignore the other failures but I think org.quarkus.infinispan.client.deployment.InfinispanConfigurationSetupTest.infinispanConnectionConfiguration is related to this update.

* Adds sniHostName and sslHostNameValidation properties

quarkus-bot · 2023-10-15T13:51:17Z

Failing Jobs - Building `3e96055`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
🚫	JVM Tests - JDK 20
✔️	Maven Tests - JDK 11
✖	Maven Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Windows - RESTEasy Jackson	`Setup GraalVM`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/oidc-client-graphql/deployment

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientAnnotation - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-graphql/deployment

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.typesafeClientAnnotation - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

...untime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientRuntimeConfig.java

michalvavrik · 2023-10-16T19:33:05Z

...untime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientRuntimeConfig.java

+     * Defaults to true.
+     */
+    @ConfigItem
+    Optional<Boolean> sslHostNameValidation;


It's unclear to me, why exactly is this optional when no default value is set via SmallRye Config. When no default value is set, then value is either true of false, no? I think setting default value would be clearer.

It's the default value in Infinispan

I'm not sure I should write this, because I don't think it is important at all, I just thought you could think about it when refactoring stuff in the future:

you document default to true, therefore whether it is default in Infinispan or not, it must be default in Quarkus, therefore saying I only set this value when user does means:

you are using Optional when not necessary, you can't just delete default value here because there is none

you are documenting default value in description instead of default value

boolean is either true or false, so not setting it to the Infinispan client later means you trust you will keep consistency and not forget when anything changes. you are not gaining anything by not setting it, just risking future inconsistency. That is - writing description and having default somewhere else than in Quarkus.

michalvavrik · 2023-10-16T19:40:24Z

...ent/runtime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientProducer.java

+                    infinispanClientRuntimeConfig.sslHostNameValidation.get());
+        }
+
+        if (infinispanClientRuntimeConfig.sniHostName.isPresent()) {


Here, you already know that sniHostName is not set, while hostname and validation is enabled. You could throw configuration exception. IMO it would be nicer than having it thrown during bean creating on startup event. But I take it you don't want to repeat validation that is already in the Infinispan client?

It's really just FYI, nothing else.

21:07:04,706 INFO [app] 21:07:03,928 Failed to start application (with profile [prod]): java.lang.RuntimeException: Failed to start quarkus 21:07:04,706 INFO [app] at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source) 21:07:04,706 INFO [app] at io.quarkus.runtime.Application.start(Application.java:101) 21:07:04,707 INFO [app] at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:111) 21:07:04,707 INFO [app] at io.quarkus.runtime.Quarkus.run(Quarkus.java:71) 21:07:04,707 INFO [app] at io.quarkus.runtime.Quarkus.run(Quarkus.java:44) 21:07:04,707 INFO [app] at io.quarkus.runtime.Quarkus.run(Quarkus.java:124) 21:07:04,707 INFO [app] at io.quarkus.runner.GeneratedMain.main(Unknown Source) 21:07:04,707 INFO [app] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 21:07:04,707 INFO [app] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) 21:07:04,707 INFO [app] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 21:07:04,707 INFO [app] at java.base/java.lang.reflect.Method.invoke(Method.java:568) 21:07:04,708 INFO [app] at io.quarkus.bootstrap.runner.QuarkusEntryPoint.doRun(QuarkusEntryPoint.java:61) 21:07:04,708 INFO [app] at io.quarkus.bootstrap.runner.QuarkusEntryPoint.main(QuarkusEntryPoint.java:32) 21:07:04,708 INFO [app] Caused by: jakarta.enterprise.inject.CreationException: Error creating synthetic bean [ddee68cd3f60c96290f55bc237588d70e5c96aab]: org.infinispan.commons.CacheConfigurationException: ISPN004112: The SNI hostname is required when hostname validation is enabled 21:07:04,708 INFO [app] at org.infinispan.client.hotrod.RemoteCacheManager_ddee68cd3f60c96290f55bc237588d70e5c96aab_Synthetic_Bean.doCreate(Unknown Source) 21:07:04,708 INFO [app] at org.infinispan.client.hotrod.RemoteCacheManager_ddee68cd3f60c96290f55bc237588d70e5c96aab_Synthetic_Bean.create(Unknown Source) 21:07:04,708 INFO [app] at org.infinispan.client.hotrod.RemoteCacheManager_ddee68cd3f60c96290f55bc237588d70e5c96aab_Synthetic_Bean.create(Unknown Source) 21:07:04,708 INFO [app] at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:113) 21:07:04,709 INFO [app] at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:37) 21:07:04,709 INFO [app] at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:34) 21:07:04,709 INFO [app] at io.quarkus.arc.impl.LazyValue.get(LazyValue.java:32) 21:07:04,709 INFO [app] at io.quarkus.arc.impl.ComputingCache.computeIfAbsent(ComputingCache.java:69) 21:07:04,709 INFO [app] at io.quarkus.arc.impl.AbstractSharedContext.get(AbstractSharedContext.java:34) 21:07:04,709 INFO [app] at io.quarkus.arc.impl.ClientProxies.getApplicationScopedDelegate(ClientProxies.java:21) 21:07:04,709 INFO [app] at org.infinispan.client.hotrod.RemoteCacheManager_ddee68cd3f60c96290f55bc237588d70e5c96aab_Synthetic_ClientProxy.arc$delegate(Unknown Source) 21:07:04,709 INFO [app] at org.infinispan.client.hotrod.RemoteCacheManager_ddee68cd3f60c96290f55bc237588d70e5c96aab_Synthetic_ClientProxy.administration(Unknown Source) 21:07:04,709 INFO [app] at io.quarkus.ts.messaging.infinispan.grpc.kafka.InfinispanPopulated.onStart(InfinispanPopulated.java:28) 21:07:04,710 INFO [app] at io.quarkus.ts.messaging.infinispan.grpc.kafka.InfinispanPopulated_Observer_onStart_acc4e7f81539047dcf8d1cef111350cdc8ea75f8.notify(Unknown Source) 21:07:04,710 INFO [app] at io.quarkus.arc.impl.EventImpl$Notifier.notifyObservers(EventImpl.java:346) 21:07:04,710 INFO [app] at io.quarkus.arc.impl.EventImpl$Notifier.notify(EventImpl.java:328) 21:07:04,710 INFO [app] at io.quarkus.arc.impl.EventImpl.fire(EventImpl.java:82) 21:07:04,710 INFO [app] at io.quarkus.arc.runtime.ArcRecorder.fireLifecycleEvent(ArcRecorder.java:155) 21:07:04,710 INFO [app] at io.quarkus.arc.runtime.ArcRecorder.handleLifecycleEvents(ArcRecorder.java:106) 21:07:04,710 INFO [app] at io.quarkus.deployment.steps.LifecycleEventsBuildStep$startupEvent1144526294.deploy_0(Unknown Source) 21:07:04,711 INFO [app] at io.quarkus.deployment.steps.LifecycleEventsBuildStep$startupEvent1144526294.deploy(Unknown Source) 21:07:04,711 INFO [app] ... 13 more 21:07:04,711 INFO [app] Caused by: org.infinispan.commons.CacheConfigurationException: ISPN004112: The SNI hostname is required when hostname validation is enabled 21:07:04,711 INFO [app] at org.infinispan.client.hotrod.configuration.SslConfigurationBuilder.validate(SslConfigurationBuilder.java:260) 21:07:04,711 INFO [app] at org.infinispan.client.hotrod.configuration.SecurityConfigurationBuilder.validate(SecurityConfigurationBuilder.java:51) 21:07:04,711 INFO [app] at org.infinispan.client.hotrod.configuration.ConfigurationBuilder.validate(ConfigurationBuilder.java:596) 21:07:04,711 INFO [app] at org.infinispan.client.hotrod.configuration.ConfigurationBuilder.build(ConfigurationBuilder.java:664) 21:07:04,711 INFO [app] at org.infinispan.client.hotrod.configuration.ConfigurationBuilder.build(ConfigurationBuilder.java:659) 21:07:04,712 INFO [app] at io.quarkus.infinispan.client.runtime.InfinispanClientProducer.initialize(InfinispanClientProducer.java:109) 21:07:04,712 INFO [app] at io.quarkus.infinispan.client.runtime.InfinispanClientProducer.getNamedRemoteCacheManager(InfinispanClientProducer.java:428) 21:07:04,712 INFO [app] at io.quarkus.infinispan.client.runtime.InfinispanRecorder$1.apply(InfinispanRecorder.java:36) 21:07:04,712 INFO [app] at io.quarkus.infinispan.client.runtime.InfinispanRecorder$1.apply(InfinispanRecorder.java:33) 21:07:04,712 INFO [app] at io.quarkus.infinispan.client.runtime.InfinispanRecorder$InfinispanClientSupplier.get(InfinispanRecorder.java:82) 21:07:04,712 INFO [app] at io.quarkus.arc.runtime.ArcRecorder$4.apply(ArcRecorder.java:129) 21:07:04,712 INFO [app] at io.quarkus.arc.runtime.ArcRecorder$4.apply(ArcRecorder.java:126) 21:07:04,712 INFO [app] at org.infinispan.client.hotrod.RemoteCacheManager_ddee68cd3f60c96290f55bc237588d70e5c96aab_Synthetic_Bean.createSynthetic(Unknown Source) 21:07:04,713 INFO [app] ... 34 more

This kind of validation depends on Infinispan, is not Quarkus logic. I won't duplicate that here, since this logic can change for security or any other reasons in Infinispan.

this logic can change for security or any other reasons in Infinispan.

But you document it, how can you document it in Quarkus and say it can change in Infinispan? It will leave Quarkus documentation inconsistent.

Anyway, I think I get your point, thanks for your answer and this PR.

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.219.0` -> `^0.220.0`](https://renovatebot.com/diffs/npm/flow-bin/0.219.0/0.220.0) | | [org.jsoup:jsoup](https://jsoup.org/) ([source](https://github.com/jhy/jsoup)) | compile | patch | `1.16.1` -> `1.16.2` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.4.3` -> `3.5.0` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | minor | `3.4.3` -> `3.5.0` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.220.0`](flow/flow-bin@f7f3f3f...030bfc6) [Compare Source](flow/flow-bin@f7f3f3f...030bfc6) ### [`v0.219.5`](flow/flow-bin@f16a6c7...f7f3f3f) [Compare Source](flow/flow-bin@f16a6c7...f7f3f3f) ### [`v0.219.4`](flow/flow-bin@9f67075...f16a6c7) [Compare Source](flow/flow-bin@9f67075...f16a6c7) ### [`v0.219.3`](flow/flow-bin@80dcea5...9f67075) [Compare Source](flow/flow-bin@80dcea5...9f67075) ### [`v0.219.2`](flow/flow-bin@c184c5d...80dcea5) [Compare Source](flow/flow-bin@c184c5d...80dcea5) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v3.5.0`](https://github.com/quarkusio/quarkus/releases/tag/3.5.0) [Compare Source](quarkusio/quarkus@3.4.3...3.5.0) ##### Complete changelog - [#36527](quarkusio/quarkus#36527) - Start MongoDB 4.4 instead of 4.0 - [#36523](quarkusio/quarkus#36523) - Minor OIDC Auth0 updates - [#36518](quarkusio/quarkus#36518) - Allow for setting logging scope programmatically - [#36517](quarkusio/quarkus#36517) - Use Mandrel 23.1 in windows CI - [#36501](quarkusio/quarkus#36501) - Let custom OIDC token propagation filters customize the exchange status - [#36495](quarkusio/quarkus#36495) - Support external OTel exporters in CDI - [#36490](quarkusio/quarkus#36490) - Take ReaderInterceptor into account when reading SSE events - [#36487](quarkusio/quarkus#36487) - Upgrade to Liquibase 4.24.0 - [#36485](quarkusio/quarkus#36485) - Fix typo in gradle-tooling.adoc - [#36474](quarkusio/quarkus#36474) - Fix some issues in getting-started-dev-services - [#36465](quarkusio/quarkus#36465) - Be more consistent in guides when creating projects/adding extensions - [#36464](quarkusio/quarkus#36464) - HTTP reference guide - HTTP/2 section update, drop JDK 8 note - [#36459](quarkusio/quarkus#36459) - Let custom OIDC token propagation filters provide client name - [#36457](quarkusio/quarkus#36457) - Update builder images to jdk-21 - [#36453](quarkusio/quarkus#36453) - Upgrade Oracle JDBC driver to 23.3.0.23.09 - [#36452](quarkusio/quarkus#36452) - Fix doc extension-add.adoc - [#36451](quarkusio/quarkus#36451) - Adjust extension name for consistency with rest of Quarkus - [#36446](quarkusio/quarkus#36446) - Regression: Liquibase fails to migrate on Quarkus start, crashing the application - [#36445](quarkusio/quarkus#36445) - Updates to Infinispan 14.0.19.Final - [#36442](quarkusio/quarkus#36442) - Use default content type when X-SSE header not set - [#36436](quarkusio/quarkus#36436) - Upgrade to Hibernate ORM 6.2.13.Final - [#36432](quarkusio/quarkus#36432) - Hibernate Reactive Panache: improve error message - [#36420](quarkusio/quarkus#36420) - Allow parallel execution of blocking health checks - [#36419](quarkusio/quarkus#36419) - Blocking Health Checks should be executed in parallel, not sequentially/ordered - [#36417](quarkusio/quarkus#36417) - Reduce timeout of the doc build to 60 minutes - [#36413](quarkusio/quarkus#36413) - Simplify virtual threads guide by pushing users to 21 - [#36412](quarkusio/quarkus#36412) - Drop Optaplanner from the documentation - [#36411](quarkusio/quarkus#36411) - Drop panache topic from Hibernate Reactive guide - [#36410](quarkusio/quarkus#36410) - Add compatibility topic to Spring guides - [#36407](quarkusio/quarkus#36407) - Register RuntimeOverrideConfigSource in STATIC_INIT - [#36406](quarkusio/quarkus#36406) - AssembleDownstreamDocumentation - print guide name - [#36400](quarkusio/quarkus#36400) - Add topics and extensions metadata to guides - [#36367](quarkusio/quarkus#36367) - Bump org.wiremock:wiremock-standalone from 3.1.0 to 3.2.0 - [#36365](quarkusio/quarkus#36365) - Bump de.flapdoodle.embed:de.flapdoodle.embed.mongo from 4.7.0 to 4.9.2 - [#36360](quarkusio/quarkus#36360) - Drop the old Dev UI guide - [#36337](quarkusio/quarkus#36337) - Upgrade maven to version 3.9.5 - [#36236](quarkusio/quarkus#36236) - No Panache session in REST endpoints defined by an interface - [#35931](quarkusio/quarkus#35931) - Add OIDC Auth0 extended tutorial - [#33548](quarkusio/quarkus#33548) - Pick random debug port when the configured one is taken - [#33363](quarkusio/quarkus#33363) - allow quarkus dev to pick random debug port </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v3.5.0`](quarkusio/quarkus-platform@3.4.3...3.5.0) [Compare Source](quarkusio/quarkus-platform@3.4.3...3.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

karesti added the triage/backport? label Oct 12, 2023

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/infinispan Infinispan labels Oct 12, 2023

This comment has been minimized.

Sign in to view

karesti force-pushed the update-infinispan branch 2 times, most recently from 0166889 to 4ae0c46 Compare October 13, 2023 12:12

This comment has been minimized.

Sign in to view

Updates to Infinispan 14.0.19.Final

3e96055

* Adds sniHostName and sslHostNameValidation properties

karesti force-pushed the update-infinispan branch from 4ae0c46 to 3e96055 Compare October 15, 2023 08:15

Sanne approved these changes Oct 15, 2023

View reviewed changes

Sanne merged commit 2265840 into quarkusio:main Oct 15, 2023
47 of 51 checks passed

quarkus-bot bot added this to the 3.6 - main milestone Oct 15, 2023

karesti deleted the update-infinispan branch October 16, 2023 07:59

michalvavrik reviewed Oct 16, 2023

View reviewed changes

michalvavrik mentioned this pull request Oct 16, 2023

Fix gRPC Infinispan tests by setting SNI as it is required when SSL is used after the latest Infinispan bump quarkus-qe/quarkus-test-suite#1473

Merged

9 tasks

gsmet modified the milestones: 3.6 - main, 3.5.0 Oct 17, 2023

gsmet removed the triage/backport? label Oct 17, 2023

michalvavrik mentioned this pull request Oct 30, 2023

Fix Infinispan client operator tests - disable hostname SNI validation and ensure cluster deleted on error quarkus-qe/quarkus-test-suite#1491

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to Infinispan 14.0.19.Final #36445

Updates to Infinispan 14.0.19.Final #36445

karesti commented Oct 12, 2023

This comment has been minimized.

Sanne commented Oct 13, 2023

gsmet commented Oct 13, 2023

This comment has been minimized.

quarkus-bot bot commented Oct 15, 2023

michalvavrik Oct 16, 2023

karesti Oct 17, 2023

michalvavrik Oct 17, 2023

michalvavrik Oct 16, 2023

karesti Oct 17, 2023 •

edited

Loading

michalvavrik Oct 17, 2023

michalvavrik Oct 17, 2023

Updates to Infinispan 14.0.19.Final #36445

Updates to Infinispan 14.0.19.Final #36445

Conversation

karesti commented Oct 12, 2023

This comment has been minimized.

Sanne commented Oct 13, 2023

gsmet commented Oct 13, 2023

This comment has been minimized.

quarkus-bot bot commented Oct 15, 2023

Failing Jobs - Building 3e96055

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/oidc-client-graphql/deployment

⚙️ JVM Tests - JDK 17 #

📦 extensions/oidc-client-graphql/deployment

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

michalvavrik Oct 16, 2023

Choose a reason for hiding this comment

karesti Oct 17, 2023

Choose a reason for hiding this comment

michalvavrik Oct 17, 2023

Choose a reason for hiding this comment

michalvavrik Oct 16, 2023

Choose a reason for hiding this comment

karesti Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

michalvavrik Oct 17, 2023

Choose a reason for hiding this comment

michalvavrik Oct 17, 2023

Choose a reason for hiding this comment

Failing Jobs - Building `3e96055`

karesti Oct 17, 2023 •

edited

Loading