Let custom OIDC token propagation filters customize the exchange status #36501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Oct 16, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
mocenas
added a commit
to mocenas/quarkus-test-suite
that referenced
this pull request
Nov 9, 2023
9 tasks
michalvavrik
pushed a commit
to quarkus-qe/quarkus-test-suite
that referenced
this pull request
Nov 10, 2023
* Implement test for OIDC filtered client Test for quarkusio/quarkus#36459 and quarkusio/quarkus#36501 * Resolve ambiguous accessTokenRequest * Add OIDC FilteredToken test to reactive
benkard
pushed a commit
to benkard/mulkcms2
that referenced
this pull request
Nov 12, 2023
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.219.0` -> `^0.220.0`](https://renovatebot.com/diffs/npm/flow-bin/0.219.0/0.220.0) | | [org.jsoup:jsoup](https://jsoup.org/) ([source](https://github.com/jhy/jsoup)) | compile | patch | `1.16.1` -> `1.16.2` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | minor | `3.4.3` -> `3.5.0` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | minor | `3.4.3` -> `3.5.0` | --- ### Release Notes <details> <summary>flowtype/flow-bin</summary> ### [`v0.220.0`](flow/flow-bin@f7f3f3f...030bfc6) [Compare Source](flow/flow-bin@f7f3f3f...030bfc6) ### [`v0.219.5`](flow/flow-bin@f16a6c7...f7f3f3f) [Compare Source](flow/flow-bin@f16a6c7...f7f3f3f) ### [`v0.219.4`](flow/flow-bin@9f67075...f16a6c7) [Compare Source](flow/flow-bin@9f67075...f16a6c7) ### [`v0.219.3`](flow/flow-bin@80dcea5...9f67075) [Compare Source](flow/flow-bin@80dcea5...9f67075) ### [`v0.219.2`](flow/flow-bin@c184c5d...80dcea5) [Compare Source](flow/flow-bin@c184c5d...80dcea5) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v3.5.0`](https://github.com/quarkusio/quarkus/releases/tag/3.5.0) [Compare Source](quarkusio/quarkus@3.4.3...3.5.0) ##### Complete changelog - [#​36527](quarkusio/quarkus#36527) - Start MongoDB 4.4 instead of 4.0 - [#​36523](quarkusio/quarkus#36523) - Minor OIDC Auth0 updates - [#​36518](quarkusio/quarkus#36518) - Allow for setting logging scope programmatically - [#​36517](quarkusio/quarkus#36517) - Use Mandrel 23.1 in windows CI - [#​36501](quarkusio/quarkus#36501) - Let custom OIDC token propagation filters customize the exchange status - [#​36495](quarkusio/quarkus#36495) - Support external OTel exporters in CDI - [#​36490](quarkusio/quarkus#36490) - Take ReaderInterceptor into account when reading SSE events - [#​36487](quarkusio/quarkus#36487) - Upgrade to Liquibase 4.24.0 - [#​36485](quarkusio/quarkus#36485) - Fix typo in gradle-tooling.adoc - [#​36474](quarkusio/quarkus#36474) - Fix some issues in getting-started-dev-services - [#​36465](quarkusio/quarkus#36465) - Be more consistent in guides when creating projects/adding extensions - [#​36464](quarkusio/quarkus#36464) - HTTP reference guide - HTTP/2 section update, drop JDK 8 note - [#​36459](quarkusio/quarkus#36459) - Let custom OIDC token propagation filters provide client name - [#​36457](quarkusio/quarkus#36457) - Update builder images to jdk-21 - [#​36453](quarkusio/quarkus#36453) - Upgrade Oracle JDBC driver to 23.3.0.23.09 - [#​36452](quarkusio/quarkus#36452) - Fix doc extension-add.adoc - [#​36451](quarkusio/quarkus#36451) - Adjust extension name for consistency with rest of Quarkus - [#​36446](quarkusio/quarkus#36446) - Regression: Liquibase fails to migrate on Quarkus start, crashing the application - [#​36445](quarkusio/quarkus#36445) - Updates to Infinispan 14.0.19.Final - [#​36442](quarkusio/quarkus#36442) - Use default content type when X-SSE header not set - [#​36436](quarkusio/quarkus#36436) - Upgrade to Hibernate ORM 6.2.13.Final - [#​36432](quarkusio/quarkus#36432) - Hibernate Reactive Panache: improve error message - [#​36420](quarkusio/quarkus#36420) - Allow parallel execution of blocking health checks - [#​36419](quarkusio/quarkus#36419) - Blocking Health Checks should be executed in parallel, not sequentially/ordered - [#​36417](quarkusio/quarkus#36417) - Reduce timeout of the doc build to 60 minutes - [#​36413](quarkusio/quarkus#36413) - Simplify virtual threads guide by pushing users to 21 - [#​36412](quarkusio/quarkus#36412) - Drop Optaplanner from the documentation - [#​36411](quarkusio/quarkus#36411) - Drop panache topic from Hibernate Reactive guide - [#​36410](quarkusio/quarkus#36410) - Add compatibility topic to Spring guides - [#​36407](quarkusio/quarkus#36407) - Register RuntimeOverrideConfigSource in STATIC_INIT - [#​36406](quarkusio/quarkus#36406) - AssembleDownstreamDocumentation - print guide name - [#​36400](quarkusio/quarkus#36400) - Add topics and extensions metadata to guides - [#​36367](quarkusio/quarkus#36367) - Bump org.wiremock:wiremock-standalone from 3.1.0 to 3.2.0 - [#​36365](quarkusio/quarkus#36365) - Bump de.flapdoodle.embed:de.flapdoodle.embed.mongo from 4.7.0 to 4.9.2 - [#​36360](quarkusio/quarkus#36360) - Drop the old Dev UI guide - [#​36337](quarkusio/quarkus#36337) - Upgrade maven to version 3.9.5 - [#​36236](quarkusio/quarkus#36236) - No Panache session in REST endpoints defined by an interface - [#​35931](quarkusio/quarkus#35931) - Add OIDC Auth0 extended tutorial - [#​33548](quarkusio/quarkus#33548) - Pick random debug port when the configured one is taken - [#​33363](quarkusio/quarkus#33363) - allow quarkus dev to pick random debug port </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v3.5.0`](quarkusio/quarkus-platform@3.4.3...3.5.0) [Compare Source](quarkusio/quarkus-platform@3.4.3...3.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
michalvavrik
pushed a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Nov 21, 2023
* Implement test for OIDC filtered client Test for quarkusio/quarkus#36459 and quarkusio/quarkus#36501 * Resolve ambiguous accessTokenRequest * Add OIDC FilteredToken test to reactive
michalvavrik
pushed a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Nov 21, 2023
* Implement test for OIDC filtered client Test for quarkusio/quarkus#36459 and quarkusio/quarkus#36501 * Resolve ambiguous accessTokenRequest * Add OIDC FilteredToken test to reactive
michalvavrik
pushed a commit
to michalvavrik/quarkus-test-suite
that referenced
this pull request
Nov 21, 2023
* Implement test for OIDC filtered client Test for quarkusio/quarkus#36459 and quarkusio/quarkus#36501 * Resolve ambiguous accessTokenRequest * Add OIDC FilteredToken test to reactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows #36459 (which in itself was correct but not complete), this time with a proper test, where both client name and now the token exchange requirement being customized at the custom filter level as opposed to in the properties.
Both
oidc-token-propagation/deploymentandoidc-token-propagation-reactive/deploymentalready test the exchange requirement configured in the properties.Relates to #36440 and #36458.