Update the documentation url to the new location #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cescoffier
commented
Jan 16, 2019
cescoffier
commented
cescoffier
added
kind/enhancement
gsmet
reviewed
Jan 16, 2019
| @@ -18,6 +18,6 @@ maven-compiler-plugin-version=3.8.0 | |||
| maven-jar-plugin-version=3.1.0 | |||
| maven-resources-plugin=3.1.0 | |||
| shamrock-version=${shamrock.version} | |||
| doc-root=http://10.8.247.58/nfs/protean | |||
| doc-root=http://10.0.144.40/nfs/protean | |||
| bom-artifactId=shamrock-bom | |||
| restAssuredVersion=${rest-assured.version} | |||
There was a problem hiding this comment.
@cescoffier unrelated to this PR but maybe we should try to be consistent in the property names e.g. maven-jar-plugin-version vs restAssuredVersion. We should avoid camel casing if you chose to use dashes.
There was a problem hiding this comment.
Here is the catch, it depends where it's used. The template engine doesn't support . and -. I'm thinking about switching to fix that or manage the difference in the Mojo code directly.
There was a problem hiding this comment.
Ah, OK, well, probably not worth it if it's a time sink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.