Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documentation url to the new location #526

Merged
merged 1 commit into from
Jan 16, 2019
+1 −1
Merged

Update the documentation url to the new location #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maven/src/main/resources/shamrock-maven-plugin.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ maven-compiler-plugin-version=3.8.0
maven-jar-plugin-version=3.1.0
maven-resources-plugin=3.1.0
shamrock-version=${shamrock.version}
doc-root=http://10.8.247.58/nfs/protean
doc-root=http://10.0.144.40/nfs/protean
bom-artifactId=shamrock-bom
restAssuredVersion=${rest-assured.version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cescoffier unrelated to this PR but maybe we should try to be consistent in the property names e.g. maven-jar-plugin-version vs restAssuredVersion. We should avoid camel casing if you chose to use dashes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the catch, it depends where it's used. The template engine doesn't support . and -. I'm thinking about switching to fix that or manage the difference in the Mojo code directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK, well, probably not worth it if it's a time sink.