Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article layout for computation chunk does not work anymore #7085

Closed
cderv opened this issue Sep 29, 2023 · 3 comments · Fixed by #7086
Closed

Article layout for computation chunk does not work anymore #7085

cderv opened this issue Sep 29, 2023 · 3 comments · Fixed by #7086
Assignees
Labels
bug Something isn't working crossref
Milestone

Comments

@cderv
Copy link
Collaborator

cderv commented Sep 29, 2023

https://quarto.org/docs/authoring/article-layout.html#multiple-outputs

Figure is not in the margin while fig-column: margin is set

image

This was found in #7078 but is really a separate issue. as knitr 1.44 was breaking the markdown output and not creating the class.
#7084 solve that one but still this issue remain

@cscheid
Copy link
Collaborator

cscheid commented Sep 29, 2023

Yeah, this one is tricky. I think this is happening because that element is not crossreferenceable (it's an image, not a figure). It gets even trickier because in 1.4, table elements can be inside figures, etc.

No, it's just broken.

@cscheid cscheid self-assigned this Sep 29, 2023
@cscheid cscheid added bug Something isn't working crossref labels Sep 29, 2023
@cscheid cscheid added this to the v1.4 milestone Sep 29, 2023
@cscheid
Copy link
Collaborator

cscheid commented Sep 29, 2023

There's a simple fix for this in src/resources/filters/layout/columns-preprocess.lua, but then the result triggers the same bug as #6961.

cscheid added a commit that referenced this issue Sep 29, 2023
@cscheid
Copy link
Collaborator

cscheid commented Sep 29, 2023

@dragonstyle This is the issue I mentioned to you. Just for our reference, here is the behavior on multiple responsive widths:

Good:

image

Not good:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crossref
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants