Correctly handles new knitr 1.44 option normalization #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change was introduced in knitr to fix quarto issues #5852 and #6576. Pre 1.44, knitr was only normalizing `fig-` to `fig.` and `out-` to `out.`. Post 1.44, knitr is normalizing from - version to . version its own known knitr chunk options. This means we need to now carefully handle backward compatibility to work with all versions. For future, this simplifies because Quarto-specific options will only be using - versions even during knitting.
…e - and . correctly - add missing hidden options created by Quarto - separate quarto opts identical to knitr ones for clarity
This is required for knitr < 1.44 compatibility as since 1.44 these options are aliased in knitr itself respectively to dev and dpi options.
This was referenced Sep 29, 2023
|
That's a good question, but I think it will require a slower answer. I think we should merge this, and consider those tests in the separate issue we opened. |
cscheid
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change was introduced in knitr to fix quarto issues #5852 and #6576.
Pre 1.44, knitr was only normalizing
fig-tofig.andout-toout..Post 1.44, knitr is normalizing from - version to . version its own known knitr chunk options.
This means we need to now carefully handle backward compatibility to work with all versions.
For future, this simplifies because Quarto-specific options will only be using - versions even during knitting.
This contribute to solve issue #7078 as
fig-columnwill be correctly forwarded as a class to the output div.However, Quarto 1.4 breaks layout when
fig-column-*is present.@cscheid how do you suggest we add some tests for the expected Markdown output so that we can prevent any breakage in knitr options handling ?