Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug stub fixes, MMU log tweak #90

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

androm3da
Copy link

No description provided.

Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
gregs 0-3 don't need special handling, so generate a TCG move
instead of calling a helper

Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
Add system registers to a total of 85 (per hex_regs.h)
Move guest registers to end
Add gelr/gsr/gosp/gbadva names for g0-g4

Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
@androm3da androm3da self-assigned this Jul 2, 2024
@quic-mathbern
Copy link

Those are the patches Taylor sent upstream, right? I think I reviewed them before and it all looked good to me.

The only possible issue I found was a dwarf_offset collision between the added registers and some of our system registers downstream. But I think shifting the downstream ones should solve this without problems.

@androm3da
Copy link
Author

Those are the patches Taylor sent upstream, right? I think I reviewed them before and it all looked good to me.

Yes -- ish. But I think there's more here than the pred reg one upstream - either that or I missed some of the patches sent to the list.

gdb-xml/hexagon-sys.xml Show resolved Hide resolved
gdb-xml/hexagon-sys.xml Show resolved Hide resolved
@quic-mathbern
Copy link

Those are the patches Taylor sent upstream, right? I think I reviewed them before and it all looked good to me.

Yes -- ish. But I think there's more here than the pred reg one upstream - either that or I missed some of the patches sent to the list.

Oh, right. I've reviewed it more carefully now. Mostly LGTM, only some comments on xml changes.

@androm3da androm3da merged commit cc9e4ca into hexagon_sysemu_20_dec_2023 Jul 8, 2024
1 check passed
@androm3da androm3da deleted the tsimpson/2_jul_2024 branch July 8, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants