Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the nested if's linter to reduce complexity globally #1158

Closed
wants to merge 23 commits into from
Closed

chore: use the nested if's linter to reduce complexity globally #1158

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f086a2b
Update .golangci.yml
faddat Feb 16, 2024
421d82d
Update .golangci.yml
faddat Feb 22, 2024
807f47d
enable nestif linter
faddat Feb 22, 2024
3e91bb5
revert changes that led to test failures
faddat Feb 22, 2024
47bb099
simplify nested if's
faddat Feb 22, 2024
48c466f
refactor SigningInfoCallback
faddat Feb 22, 2024
088e385
refactor ValidateClaim
faddat Feb 22, 2024
cce08f2
simplify genaccounts.go
faddat Feb 23, 2024
3a1890a
refactor handlewithdrawforuser
faddat Feb 23, 2024
1731968
matching withdrawal
faddat Feb 23, 2024
938a9ab
Merge remote-tracking branch 'origin/main' into HEAD
faddat Mar 8, 2024
68291dc
refactor SetValidatorsForZone
faddat Mar 8, 2024
280d3c4
more simplification
faddat Mar 8, 2024
b59babd
Merge remote-tracking branch 'origin/main' into faddat-patch-2
faddat Mar 16, 2024
54974cb
update .golangci.yml
faddat Mar 21, 2024
2e16c9e
Merge remote-tracking branch 'origin/main' into faddat-patch-2
faddat Mar 21, 2024
48d8543
Merge branch 'main' into faddat-patch-2
tuantran1702 Mar 28, 2024
b4540b5
fix syntax error and lint
tuantran1702 Mar 28, 2024
24f448e
pass pointer as argument to mutate the validator
tuantran1702 Mar 28, 2024
0d21044
refactor reduntant err!=nil check
tuantran1702 Mar 29, 2024
e7dd00d
extract sanity check to other func
tuantran1702 Mar 29, 2024
d873bc6
disable gocognit lint for cmd and app function
tuantran1702 Mar 29, 2024
690bd5c
Merge branch 'main' into faddat-patch-2
tuantran1702 Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ linters:
- gosimple
- govet
- ineffassign
- maintidx
- misspell
- nakedret
- staticcheck
Expand Down Expand Up @@ -62,10 +63,6 @@ linters-settings:
# Do NOT whine about the following, full explanation found in:
# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#description-of-available-rules
rules:
- name: use-any
disabled: true
- name: if-return
disabled: true
- name: max-public-structs
disabled: true
- name: unchecked-type-assertion
Expand Down Expand Up @@ -102,12 +99,8 @@ linters-settings:
disabled: true
- name: confusing-results
disabled: true
- name: unused-parameter
disabled: true
- name: modifies-value-receiver
disabled: true
- name: early-return
disabled: true
- name: confusing-naming
disabled: true
- name: defer
Expand Down
Loading