HTML Reporter: Fuzzy search using fuzzysort #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ventuno
force-pushed
the
ftr-1438-fuzzysort
branch
from
f35939a to
4434e5c
Compare
ventuno
changed the title
|
Thanks @trentmwillis, when is the next release planned? |
|
We don't have regularly scheduled releases. That said, I can probably cut a new release this weekend assuming no other bugs/features come up that we'd want to wait for. Will likely be a patch release since this shouldn't affect how tests run at all. |
|
That's great. Thanks a lot for your help! |
ventuno
added a commit
to ventuno/qunit
that referenced
this pull request
Jun 13, 2020
This reverts commit 474a708.
|
@trentmwillis I see a new release was made, but I don't see this feature in the latest version. Any chance we could get this out? |
Krinkle
added a commit
that referenced
this pull request
Aug 16, 2020
Follows-up 474a708, which added fuzzysort.js, which has an undocumented dependency on ES6 Map (whilst publishing its code in UMD/ES5-syntax). Restore IE 10 compat by adding a simple inline fallback (it only needs to work with strings). Also: * Restore ESLint settings on test/main/ to explicitly disable es6. This used to be the default (we enable es6:true on /src/ and /test/cli), but now that ESLint enables it by default we need to disable it to flag its use. * Fix the handful of syntaxes that were introduced and caused tests to fail as a result. Ref #1440.
Krinkle
added a commit
that referenced
this pull request
Aug 16, 2020
Follows-up 474a708, which added fuzzysort.js, which has an undocumented dependency on ES6 Map (whilst publishing its code in UMD/ES5-syntax). Restore IE 10 compat by adding a simple inline fallback (it only needs to work with strings). Also: * Restore ESLint settings on test/main/ to explicitly disable es6. This used to be the default (we enable es6:true on /src/ and /test/cli), but now that ESLint enables it by default we need to disable it to flag its use. * Fix the handful of syntaxes that were introduced and caused tests to fail as a result. Ref #1440.
|
Thanks for the update @Krinkle :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample implementation of: #1438 (
fuzzysort-based).Below search results with different keywords (on
test/index.html). The examples below use different values offuzzysort'sthresholdoption.-10000is the value used infuzzysort's documentation: How To Go Fast · Performance Tips section.Searches with
thresholdundefined(default)Search: "assert".
Search: "beforeEach".
Search: "promiseaware".
Search: "script".
Searches with
threshold-10000Search: "assert".
Search: "beforeEach".
Search: "promiseaware".
Search: "script".
