HTML Reporter: Add basic ES6 Map fallback for fuzzysort.js #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows-up 474a708, which added fuzzysort.js, which has an undocumented dependency on ES6 Map (whilst publishing its code in UMD/ES5-syntax). Restore IE 10 compat by adding a simple inline fallback (it only needs to work with strings). Also: * Restore ESLint settings on test/main/ to explicitly disable es6. This used to be the default (we enable es6:true on /src/ and /test/cli), but now that ESLint enables it by default we need to disable it to flag its use. * Fix the handful of syntaxes that were introduced and caused tests to fail as a result. Ref #1440.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows-up 474a708, which added fuzzysort.js, which has an
undocumented dependency on ES6 Map (whilst publishing its code
in UMD/ES5-syntax).
Restore IE 10 compat by adding a simple inline fallback
(it only needs to work with strings).
Also:
es6. This used to be the default (we enable es6:true on /src/
and /test/cli), but now that ESLint enables it by default we need
to disable it to flag its use.
tests to fail as a result.
Ref #1440.