-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: QUnit.equiv major ES6 refactor & optimizations [Step 2] #1701
base: main
Are you sure you want to change the base?
Conversation
Small removals/adjustments to make the code more readable.
Makes code more readable and removes variable mutations in compareConstructors().
@izelnakri I believe most of these have landed since in commits at https://github.com/qunitjs/qunit/commits/main/src/equiv.js. Mainly fec7c1a. The one part that I haven't landed yet is the passing down of I did not see a consistent difference in the benchmark, though. Perhaps you'd like to have a look to check that 1) I've applied it correctly, or 2) perhaps benchmark it differently.
|
This PR introduces further refactors and optimizations based on #1700
Certain changes probably require QUnit to update its browser policy and deprecate support for certain browsers.
I'm confident that each commit should result in faster deepEqual checks, except the last one. The last commit particularly needs to be benchmarked I think.
I seperated each refactor to its seperate commit. Have a look, I think you'll find it very interesting! :)