Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 18674 tools::toTitleCase() #172

Closed

Conversation

shannonpileggi
Copy link

Bug 18674 tools::toTitleCase() incorrectly capitalizes conjunctions (e.g. 'and') when using suspensive hyphenation corrected.

Also fixed spacing in documentation, added two examples in documentation, and added two tests for the fix.

@shannonpileggi
Copy link
Author

fyi @sarahzeller @reikookamoto @Bisaloo

@mmaechler
Copy link

Committed to R's sources now, w/ even more examples (+ NEWS + tools-Ex.Rout.save).
Thank you very much!

NB (also to myself!):

  1. Appending .diff to the end of the URL automatically provides something you save from your browser as plain text file, named, e.g., toTitleCase_PR-18674.diff and then
  2. in R's bugzilla, you'd typically use the Add an Attachment option to add that *.diff file as attachment:
    - on the new Create New Attachment web page, add a Brief Decription ,
    - also click the Content Type: patch box, and then
    - add comments (often prose text) below rather than in the original bugzilla page for the PR.
    - press Submit

This will give you a perfect bugzilla submission, with only one e-mail to all of R-core plus PR author and more listeners.

@MichaelChirico
Copy link
Collaborator

Linking here for convenience: https://bugs.r-project.org/show_bug.cgi?id=18674

@shannonpileggi
Copy link
Author

Thank you @mmaechler for the detailed instructions and the feedback! I have added an issue to the contribution to guide to assess if we could use more information there.

r-devel/rdevguide#177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants