-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicit patch submission instructions #177
Comments
I think this is very useful and it would be great to add it to the book to annotate what was previously shared on individual cases. |
Thanks for the tag @llrs and I agree with you that it would be great to add this to the dev guide. @shannonpileggi - would you like to open a PR about the same? |
Sure, will do! Thanks for the feedback! |
Recently at R Dev Day PLUS, Martin commented on how to submit the "perfect" patch. I see a related section in 7.4.1 & 7.6, but I don't think it as explicitly goes through all the steps regarding the attachment and such??
r-devel/r-svn#172 (comment)
Appending
.diff
to the end of the [r-svn PR] URL automatically provides something you save from your browser as plain text file, named, e.g.,toTitleCase_PR-18674.diff
and thenin R's bugzilla, you'd typically use the Add an Attachment option to add that *.diff file as attachment:
This will give you a perfect bugzilla submission, with only one e-mail to all of R-core plus PR author and more listeners.
vs what was initially submitted:
https://bugs.r-project.org/show_bug.cgi?id=18674
fyi @sarahzeller @reikookamoto @Bisaloo
The text was updated successfully, but these errors were encountered: