Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit patch submission instructions #177

Closed
shannonpileggi opened this issue Jul 16, 2024 · 3 comments · Fixed by #180
Closed

explicit patch submission instructions #177

shannonpileggi opened this issue Jul 16, 2024 · 3 comments · Fixed by #180

Comments

@shannonpileggi
Copy link
Contributor

Recently at R Dev Day PLUS, Martin commented on how to submit the "perfect" patch. I see a related section in 7.4.1 & 7.6, but I don't think it as explicitly goes through all the steps regarding the attachment and such??

r-devel/r-svn#172 (comment)

Appending .diff to the end of the [r-svn PR] URL automatically provides something you save from your browser as plain text file, named, e.g., toTitleCase_PR-18674.diff and then
in R's bugzilla, you'd typically use the Add an Attachment option to add that *.diff file as attachment:

  • on the new Create New Attachment web page, add a Brief Decription ,
  • also click the Content Type: patch box, and then
  • add comments (often prose text) below rather than in the original bugzilla page for the PR.
  • press Submit
    This will give you a perfect bugzilla submission, with only one e-mail to all of R-core plus PR author and more listeners.

vs what was initially submitted:
https://bugs.r-project.org/show_bug.cgi?id=18674

fyi @sarahzeller @reikookamoto @Bisaloo

@llrs
Copy link
Member

llrs commented Jul 16, 2024

I think this is very useful and it would be great to add it to the book to annotate what was previously shared on individual cases.
Perhaps @SaranjeetKaur who originally wrote the section can provide more feedback (or add it to the book).

@SaranjeetKaur
Copy link
Collaborator

SaranjeetKaur commented Jul 16, 2024

Thanks for the tag @llrs and I agree with you that it would be great to add this to the dev guide.

@shannonpileggi - would you like to open a PR about the same?

@shannonpileggi
Copy link
Contributor Author

Sure, will do! Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants