Change the default failure in parse_http_date() to NA with class Date (…

…#544) Otherwise, print.response() may throw an unfriendly error.
r-lib · Nov 22, 2018 · 5345aaf · 5345aaf
1 parent 2564b85
commit 5345aaf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # httr 1.3.1.9000
 
+* The default value of `failure` argument in `parse_http_date()` is set to `structure(NA_real_, class = "Date")` so that the reponse with a "failure" date can be printed out correctly. (@shrektan, #544)
+
 # httr 1.3.1
 
 * Re-enable on-disk caching (accidentally disabled in #457) (#475)

diff --git a/R/date.R b/R/date.R
@@ -21,7 +21,7 @@
 #' parse_http_date("Sun Nov 6 08:49:37 1994")
 #'
 #' http_date(Sys.time())
-parse_http_date <- function(x, failure = NA) {
+parse_http_date <- function(x, failure = structure(NA_real_, class = "Date")) {
  if (length(x) == 0) return(NULL)
 
  fmts <- c(

diff --git a/man/parse_http_date.Rd b/man/parse_http_date.Rd