Change the default failure in parse_http_date() to NA with class Date #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of
failure
argument inparse_http_date()
should be NA with class Date.Otherwise,
print.response()
may throw an unfriendly error.On a Chinese-language Windows machine, I use plumber to build an REST API. The API returns the
header$date
in Chinese format by default, like "周三, 10 十月 2018 1:19:13 GMT".parse_http_date()
will fail to parse it correctly and fall back to the default value of `failure``.However, the default value of
failure
is set toNA
(the logical value). Whenever I try to print the response, R will throw error saying:Error in prettyNum(.Internal(format(x, trim, digits, nsmall, width, 3L, : invalid 'trim' argument
I believe the cause is
httr/R/response.r
Line 35 in 976289a
After this PR, the result can be printed successfully now.