Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary error on failure to parse headers$Date #529

Closed
wants to merge 1 commit into from

Conversation

stefanfritsch
Copy link

Hi,

when parsing the headers$Date in request_perform fails, e.g. because the response is not in en_US it results in an unhelpful prettyNum (or so) error.

I just split the if-else to replace the date with something valid if it failed to parse.

Ciao,
Stefan

@hadley
Copy link
Member

hadley commented Nov 22, 2018

Could you please give me an example of the error that this resolves? I don't understand what you mean by prettyNum

@hadley
Copy link
Member

hadley commented Nov 22, 2018

Oh I see this is a duplicate of #544, which explains the problem better.

@hadley hadley closed this Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants