Allow absolute path as argument to F <- make_fix_file() #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling the accessor returned by make_fix_file() with an absolute path as first argument appends to the provided path instead of to the root path if the provided path is inside the root path.
Author
|
Obsolete with #59 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal to fix r-lib/here#34 – appending to paths created by
here():If the first argument to the function produced by
criterion$make_fix_file()starts with the saved root, base the path on the first argument instead of the saved root.This change shouldn't break existing code as the current implementation always produces invalid paths when nesting
here().Further nesting or using a path outside the project root still won't return anything useful, but I can't really think of how that would make sense in the context of the
here()function.It would fix the first part (
safe_here) of the related r-lib/here#31 (comment).The second part asks for optionally returning the path relative to the current working directory, as in r-lib/here#36, which sounds like a separate issue to me.