Return absolute paths unchanged #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krlmlr Makes sense and seems to be a great solution to dealing with a combination of absolute and relative paths. Thanks for working on it! |
|
@krlmlr |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 81.25% 80.00% -1.25%
==========================================
Files 5 6 +1
Lines 192 185 -7
==========================================
- Hits 156 148 -8
- Misses 36 37 +1
Continue to review full report at Codecov.
|
|
Looks great, thanks a lot for your work, this will definitely improve my workflow. |
Member
Author
|
Thanks for your feedback! |
|
Looking good! Thanks! |
|
@krlmlr That makes sense to me. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first component is already an absolute path, everything is returned unchanged. This applies to
find_root_file()and the criteria's "member functions".Fixes r-lib/here#34, fixes r-lib/here#31.
Closes #46.
@jthurner @StevenMMortimer @czeildi @lgaborini: Would that make {here} easier to use?
@yihui: What do you think about this approach for handling paths that are already absolute, in {here} and {rprojroot}?