R6 methods don't allow multi-line formals?

[MichaelChirico]

The following should be allowed (ref: https://style.tidyverse.org/functions.html#long-lines-1 doesn't mention R6):

R6Class("MyClass",
  public = list(
    param = NULL,
    initialize = function(
        my_long_parameter = getOption("default_long_parameter", 1)) {
      self$param <- my_long_parameter
    }
  )
)

But it's currently re-styled (style_text() output):

R6Class("MyClass",
  public = list(
    param = NULL,
    initialize = function(my_long_parameter = getOption("default_long_parameter", 1)) {
      self$param <- my_long_parameter
    }
  )
)

Which of course creates an over-full line.

[lorenzwalthert]

Right… but I think in your example, you only put one level of indention. Shouldn’t it be

R6Class("MyClass",
  public = list(
    param = NULL,
    initialize = function(
        my_long_parameter = getOption("default_long_parameter", 1)) {
      self$param <- my_long_parameter
    }
  )
)

[MichaelChirico]

ah yes, my mistake. edited in the description

[lorenzwalthert]

Seems like detection of double indention is based on the absolute indention of the formals, instead of the relative...

[lorenzwalthert]

This is actually fixed with #1235 I belive, as double indention is not allowed anymore. Can you double check @MichaelChirico?

[MichaelChirico]

Unfortunately no, the same bug still applies to the new style guide approach:

styler::style_text(R"(
R6Class("MyClass",
  public = list(
    param = NULL,
    initialize = function(
      my_long_parameter = getOption("default_long_parameter", 1)
    ) {
      self$param <- my_long_parameter
    }
  )
)
)")

gives output

R6Class("MyClass",
  public = list(
    param = NULL,
    initialize = function(my_long_parameter = getOption("default_long_parameter", 1)) {
      self$param <- my_long_parameter
    }
  )
)

[MichaelChirico]

(updated the bug title since it's not about double-indentation per se, but about declaring R6 methods with multi-line formals, under either old or new guide style)

[lorenzwalthert]

Seems not a problem in unnested case:

styler::style_text('initialize <- function(
    my_long_parameter = getOption("default_long_parameter", 1)) {
  self$param <- my_long_parameter
}')
#> Warning: Could not use `colored = TRUE`, as the package prettycode is not installed.
#> Please install it if you want to see colored output or see
#> `?styler::print.vertical()` for more information.
#> initialize <- function(
#>     my_long_parameter = getOption("default_long_parameter", 1)) {
#>   self$param <- my_long_parameter
#> }

^{Created on 2024-12-05 with reprex v2.1.0}

[MichaelChirico]

This still applies after the changes for the new formatting rules in 1.11.0.

[lorenzwalthert]

I am open to PRs 😊