Skip to content

Conversation

@lorenzwalthert
Copy link
Collaborator

Closes #1027.

@lorenzwalthert lorenzwalthert changed the title Run some tests sequentially. Run some tests sequentially Oct 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Merging #1031 (ddba306) into main (c6b978b) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
- Coverage   91.20%   91.08%   -0.13%     
==========================================
  Files          46       46              
  Lines        2683     2691       +8     
==========================================
+ Hits         2447     2451       +4     
- Misses        236      240       +4     
Impacted Files Coverage Δ
R/testing.R 66.66% <0.00%> (-1.95%) ⬇️
R/indent.R 100.00% <0.00%> (ø)
R/rules-line-breaks.R 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant solution. Thanks!

@IndrajeetPatil IndrajeetPatil merged commit 38e4b1f into main Oct 16, 2022
@IndrajeetPatil IndrajeetPatil deleted the issue-1027 branch October 16, 2022 14:25
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 897884d is merged into main:

  •   :ballot_box_with_check:cache_applying: 30.1ms -> 30.3ms [-0.89%, +2.04%]
  •   :ballot_box_with_check:cache_recording: 802ms -> 798ms [-1.3%, +0.32%]
  •   :ballot_box_with_check:without_cache: 1.98s -> 1.98s [-0.19%, +0.67%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speed test fail randomly with {testthat} 3e parallel running

4 participants