Skip to content

Conversation

@lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Nov 7, 2022

Closes #1044.
Prepare for release:

  • devtools::check_win_devel()
  • Polish NEWS
  • add tidy thanks.
  • If new failures, update email.yml then revdepcheck::revdep_email_maintainers()
  • update cran-comments.md
  • run urlchecker::url_check("path/to/pkg")

Perform release:

  • Create RC branch (for bigger releases)
  • Bump version (in DESCRIPTION and NEWS)
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Tag release
  • [] Merge RC back to master branch
  • Bump dev version
  • update CRAN speed change monitor PR.We have a new CRAN release coming up 🥳 See NEWS.md for new features.

@lorenzwalthert lorenzwalthert changed the title release version 1.8.1 Release version 1.8.1 Nov 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1053 (76d2358) into main (bf6524d) will not change coverage.
The diff coverage is n/a.

❗ Current head 76d2358 differs from pull request most recent head c2e0d9a. Consider uploading reports for the commit c2e0d9a to get more accurate results

@@           Coverage Diff           @@
##             main    #1053   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files          46       46           
  Lines        2682     2682           
=======================================
  Hits         2442     2442           
  Misses        240      240           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8b2b6e6 is merged into main:

  •   :ballot_box_with_check:cache_applying: 26.5ms -> 26.6ms [-0.51%, +1.33%]
  •   :ballot_box_with_check:cache_recording: 821ms -> 822ms [-0.58%, +0.65%]
  •   :ballot_box_with_check:without_cache: 2.07s -> 2.07s [-0.45%, +0.4%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator Author

@IndrajeetPatil all checks green. Are we good to go?

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for submission, @lorenzwalthert! Thanks.

@lorenzwalthert
Copy link
Collaborator Author

Submitted. Let's see.

@lorenzwalthert lorenzwalthert merged commit ad2e2db into main Nov 8, 2022
@lorenzwalthert lorenzwalthert deleted the rc-1.8.1 branch November 8, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRAN re-submission

4 participants