Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone should not be styled #1135

Closed
wants to merge 2 commits into from
Closed

Standalone should not be styled #1135

wants to merge 2 commits into from

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #1134.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if acd0b46 is merged into main:

  •   :ballot_box_with_check:cache_applying: 167ms -> 168ms [-0.56%, +2.51%]
  •   :ballot_box_with_check:cache_recording: 620ms -> 620ms [-0.43%, +0.54%]
  •   :ballot_box_with_check:without_cache: 1.19s -> 1.19s [-0.22%, +0.3%]

Further explanation regarding interpretation and methodology can be found in the documentation.

lorenzwalthert
lorenzwalthert commented Jun 29, 2023
View reviewed changes
R/ui-styling.R
@@ -69,7 +69,7 @@ style_pkg <- function(pkg = ".",
style = tidyverse_style,
transformers = style(...),
filetype = c("R", "Rprofile", "Rmd", "Rmarkdown", "Rnw", "Qmd"),
exclude_files = c("R/RcppExports.R", "R/cpp11.R"),
exclude_files = c("R/RcppExports.R", "R/cpp11.R", "R/import-standalone.+R"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exclude_files = c("R/RcppExports.R", "R/cpp11.R", "R/import-standalone.+R"),
exclude_files = c("R/RcppExports\\.R", "R/cpp11\\.R", "R/import-standalone.+\\.R"),

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

escape dots for regex.

@lorenzwalthert
Copy link
Collaborator Author

Thanks @olivroy. I will review later. exclude_files should be regex only (not regex and file path), otherwise it's too ambigous IMO.

@lorenzwalthert lorenzwalthert mentioned this pull request Jul 16, 2023
Merged
@lorenzwalthert
Copy link
Collaborator Author

Closed in favor of #1135.

lorenzwalthert added a commit that referenced this pull request Sep 24, 2023
@lorenzwalthert
Merge pull request #1138 from r-lib/standalone
12f7eb6 
Follow up:  Standalone should not be styled #1135
@olivroy olivroy deleted the standalone branch February 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

standalone files imported from other packages should be ignored in style_pkg()
2 participants
@lorenzwalthert @olivroy