-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Introduce line-breaks in multiline arguments #1244
base: main
Are you sure you want to change the base?
Conversation
…b/styler into f209-newline-multiline-args
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Wow, that's quite the slowdown. Need to figure out what's causing it once the scope is clear. |
This comment was marked as outdated.
This comment was marked as outdated.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 27b5eca is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
@lorenzwalthert Any thoughts? I am blocked here without any further feedback from the team. |
Maybe we should talk about the abstract rule first. What is it exactly that we try to achieve? Also important: in the example you gave, all line breaks should simply be removed if we had #247. |
cf. tidyverse/style#209
Creating an early PR because I'm having a hard time figuring out the scope of this change. The motivating issue and the style guide don't go into too much depth as to when one should introduce line breaks in the context of multi-line arguments. But this should act as a good starting point.
This is an adapted version of a similar feature in grkstyle.
Examples
Created on 2024-12-06 with reprex v2.1.1