Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for base R pipe #803

Merged
merged 3 commits into from
May 25, 2021
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented May 25, 2021

Closes #800.

@codecov-commenter
Copy link

Codecov Report

Merging #803 (a311626) into master (2985c84) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a311626 differs from pull request most recent head 14aae7d. Consider uploading reports for the commit 14aae7d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   90.46%   90.46%           
=======================================
  Files          47       47           
  Lines        2433     2433           
=======================================
  Hits         2201     2201           
  Misses        232      232           
Impacted Files Coverage Δ
R/rules-indention.R 100.00% <ø> (ø)
R/token-define.R 66.66% <ø> (ø)
R/relevel.R 46.15% <100.00%> (ø)
R/rules-line-breaks.R 100.00% <100.00%> (ø)
R/rules-tokens.R 100.00% <100.00%> (ø)
R/style-guides.R 99.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2985c84...14aae7d. Read the comment docs.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if a311626 is merged into master:

  • cache_applying: 0.11s -> 0.11s [-1.79%, +5.87%]
  • cache_recording: 1.27s -> 1.28s [-0.41%, +2.09%]
  • without_cache: 3.33s -> 3.34s [-0.76%, +1.16%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 786d174 into r-lib:master May 25, 2021
@lorenzwalthert lorenzwalthert deleted the issue-800 branch May 25, 2021 20:55
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confience interval in relative change) if a311626 is merged into master:

  • cache_applying: 0.09s -> 0.09s [-4.69%, +1.72%]
  • cache_recording: 1.14s -> 1.14s [-0.25%, +0.52%]
  • without_cache: 3.02s -> 3.02s [-0.78%, +1.16%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support formatting the R base pipe |> akin to %>%
2 participants