Reject styling wrongly parsed coder #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
R/parse.R
Outdated
| if (any(is_unicode_parsing_error)) { | ||
| rlang::abort( | ||
| "Can't parse input due to unicode restriction in base R. Please ", | ||
| "upgrade R to style this input. ", |
Collaborator
There was a problem hiding this comment.
Maybe you can specify the exact version of R here that the user needs to upgrade to?
Collaborator
Author
There was a problem hiding this comment.
Thanks, I adapted it.
lorenzwalthert
force-pushed
the
issue-847
branch
from
1cd9ec8 to
1b0f5ea
Compare
Codecov Report
@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 89.76% 89.63% -0.13%
==========================================
Files 47 47
Lines 2500 2509 +9
==========================================
+ Hits 2244 2249 +5
- Misses 256 260 +4
Continue to review full report at Codecov.
|
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if a33c2ab is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #847. Turns out we can't fix the problem because we can't construct a string like
"\U2660"from "\U" and 2660: Error: '\U' used without hex digits in character string starting ""\U"". So windows users have to wait for R 4.2. @IndrajeetPatil I added a test to make sure it errors under certain circumstances.