addition of attributes for downloading deb, rpm and esl-erlang-compat

[dannietjoh]

added attributes that allow configuration of the download url and package name for rabbitmq deb and rpm and esl-erlang-compat rpm, for example for those that do not have the luxury to connect production environments to the outside world.

[jjasghar]

Please add some specs for these changes.

[dannietjoh]

Hi,

I'll be glad to but I'm not quite sure how to add more to the spec tests than is provided, both rabbitmq deb and rpm files already have checks for availability in the cache path and checks for installation.
The esl-erlang-compat package depends on attributes from the erlang cookbook making it hard to build a spec for.

[jujugrrr]

Please add some specs for these changes.

It seems there are already specs to test we are getting the appropriate files :
https://github.com/jjasghar/rabbitmq/blob/master/spec/default_spec.rb#L89-L95
https://github.com/jjasghar/rabbitmq/blob/master/spec/default_spec.rb#L119-L127

If this PR passes tests, it means the new attributes are not breaking the expected/previous behaviour, but allow to change the source if you need to, which is good.

We could add some context in the specs changing the attributes and testing it's not using parameters for remote_files, but I'm not sure of the value to do so.

In addition in the specs we already use the version https://github.com/jjasghar/rabbitmq/blob/master/spec/default_spec.rb#L79. , so those new attribute are tested.

We really need this PR, because lately https://www.rabbitmq.com/releases/rabbitmq-server has been really unreliable for us.

ps : thanks for the Pr @dannietjoh

[kgeorgak]

I agree with the comments made by @jujugrrr.

The existing tests should be enough as they test the creation of the remote file. If the attributes don't have the correct value the test will flag it.

[cmluciano]

I cherry-picked this and am testing now

[nakedpony]

It's a really nice PR especially now when rabbitmq artifacts are non accessible on official site. Please read https://groups.google.com/forum/#!topic/rabbitmq-users/Ov0k_Xp0C3Y

[Igorshp]

👍 looking forward to seeing this merged.
the RabbitMQ hosting maintenance, is causing problems for our chef runs.

[cmluciano]

working on getting this released this week. Thank you for your patience.