Skip to content

Conversation

@gomoripeti
Copy link
Contributor

@gomoripeti gomoripeti commented Oct 1, 2024

Proposed Changes

This plugin still uses a pair of Mnesia tables. If not running, Mnesia is started in a single-node cluster mode. This is enough, as the used tables are not replicated.

(As discussed in #291)

CT tests to be added.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

This plugin still uses a pair of Mnesia tables. If not running, Mnesia
is started in a single-node cluster mode. This is enough, as the used
tables are not replicated.
@michaelklishin michaelklishin added this to the 4.0.2 milestone Oct 2, 2024
@michaelklishin
Copy link
Contributor

This version does work with Khepri enabled. I am testing an "upgrade" to Khepri next.

@michaelklishin
Copy link
Contributor

A switch to Khepri with a node restart works as expected. Thank you, @gomoripeti.

@michaelklishin michaelklishin merged commit 18d8135 into rabbitmq:main Oct 2, 2024
3 of 4 checks passed
@gomoripeti gomoripeti deleted the 4_0 branch October 2, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants