forked from thanos-io/thanos
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downsampling v2 (wip) #4
Draft
rabenhorst
wants to merge
9
commits into
native-histogram-support-downsampling
Choose a base branch
from
downsampling-v2
base: native-histogram-support-downsampling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Fixed imports Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Added native histogram support for downsampling Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Improved comment Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Removed unnecessary if Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Fixed native histogram proto conversion in remote engine Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Added downsampling support for native histograms Reverted files from base PR Added changelog Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Reverted error in bucket.go Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> trigger tests Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Fixed tests, removed unused code Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com> Fixed tests, removed unused code Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
rabenhorst
force-pushed
the
native-histogram-support-downsampling
branch
from
July 31, 2023 10:09
0415cc4
to
979c139
Compare
rabenhorst
force-pushed
the
native-histogram-support-downsampling
branch
2 times, most recently
from
August 19, 2023 17:45
c0cfcc6
to
c402aaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poc for downsampling using the Thanos engine for aggregate calculation. Relates to https://github.com/Shopify/thanos/pull/214.