Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsampling v2 (wip) #4

Draft
wants to merge 9 commits into
base: native-histogram-support-downsampling
Choose a base branch
from

Conversation

rabenhorst
Copy link
Owner

@rabenhorst rabenhorst commented Jul 27, 2023

Poc for downsampling using the Thanos engine for aggregate calculation. Relates to https://github.com/Shopify/thanos/pull/214.

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Fixed imports

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Added native histogram support for downsampling

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Improved comment

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Removed unnecessary if

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Fixed native histogram proto conversion in remote engine

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Added downsampling support for native histograms

Reverted files from base PR

Added changelog

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Reverted error in bucket.go

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

trigger tests

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Fixed tests, removed unused code

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>

Fixed tests, removed unused code

Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
@rabenhorst rabenhorst force-pushed the native-histogram-support-downsampling branch from 0415cc4 to 979c139 Compare July 31, 2023 10:09
@rabenhorst rabenhorst force-pushed the native-histogram-support-downsampling branch 2 times, most recently from c0cfcc6 to c402aaa Compare August 19, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant