Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsampling v2 (wip) #4

Draft
wants to merge 9 commits into
base: native-histogram-support-downsampling
Choose a base branch
from
Draft

Downsampling v2 (wip) #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
faef3c8
Added native histogram support for downsampling
rabenhorst Apr 28, 2023
b0fe416
Fixed tests, removed unused code
rabenhorst Jun 13, 2023
0415cc4
Added test for mixed types and gauge reset fix
rabenhorst Jul 24, 2023
34155dc
Add downsampling v2 (wip)
rabenhorst Jul 27, 2023
59f3351
Improved downsampling
rabenhorst Jul 27, 2023
8eab858
Add aggregate chunk builder
rabenhorst Jul 27, 2023
84bc9fb
Added aggregate aggregation
rabenhorst Jul 28, 2023
1756467
Improved tests, fixed bugs
rabenhorst Jul 28, 2023
d6f1d12
Fixed imports
rabenhorst Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
- [#6163](https://github.com/thanos-io/thanos/pull/6163) Receiver: changed max backoff from 30s to 5s for forwarding requests. Can be configured with `--receive-forward-max-backoff`.
- [#6327](https://github.com/thanos-io/thanos/pull/6327) *: *breaking :warning:* Use histograms instead of summaries for instrumented handlers.
- [#6322](https://github.com/thanos-io/thanos/pull/6322) Logging: Avoid expensive log.Valuer evaluation for disallowed levels.
- [#6350] https://github.com/thanos-io/thanos/pull/6350 Compact: Add native histogram support for downsampling.
- [#6358](https://github.com/thanos-io/thanos/pull/6358) Query: Add +Inf bucket to query duration metrics
- [#6363](https://github.com/thanos-io/thanos/pull/6363) Store: Check context error when expanding postings.
- [#6405](https://github.com/thanos-io/thanos/pull/6405) Index Cache: Change postings cache key to include the encoding format used so that older Thanos versions would not try to decode it during the deployment of a new version.
Expand Down
10 changes: 5 additions & 5 deletions pkg/compact/downsample/aggr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ import (
func TestAggrChunk(t *testing.T) {
var input [5][]sample

input[AggrCount] = []sample{{100, 30}, {200, 50}, {300, 60}, {400, 67}}
input[AggrSum] = []sample{{100, 130}, {200, 1000}, {300, 2000}, {400, 5555}}
input[AggrMin] = []sample{{100, 0}, {200, -10}, {300, 1000}, {400, -9.5}}
input[AggrCount] = []sample{{t: 100, v: 30}, {t: 200, v: 50}, {t: 300, v: 60}, {t: 400, v: 67}}
input[AggrSum] = []sample{{t: 100, v: 130}, {t: 200, v: 1000}, {t: 300, v: 2000}, {t: 400, v: 5555}}
input[AggrMin] = []sample{{t: 100}, {t: 200, v: -10}, {t: 300, v: 1000}, {t: 400, v: -9.5}}
// Maximum is absent.
input[AggrCounter] = []sample{{100, 5}, {200, 10}, {300, 10.1}, {400, 15}, {400, 3}}
input[AggrCounter] = []sample{{t: 100, v: 5}, {t: 200, v: 10}, {t: 300, v: 10.1}, {t: 400, v: 15}, {t: 400, v: 3}}

var chks [5]chunkenc.Chunk

Expand All @@ -41,7 +41,7 @@ func TestAggrChunk(t *testing.T) {
for _, at := range []AggrType{AggrCount, AggrSum, AggrMin, AggrMax, AggrCounter} {
if c, err := ac.Get(at); err != ErrAggrNotExist {
testutil.Ok(t, err)
testutil.Ok(t, expandChunkIterator(c.Iterator(nil), &res[at]))
testutil.Ok(t, expandXorChunkIterator(c.Iterator(nil), &res[at]))
}
}
testutil.Equals(t, input, res)
Expand Down
Loading