Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump twisted from 20.3.0 to 22.1.0 #236

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 11, 2022

Bumps twisted from 20.3.0 to 22.1.0.

Release notes

Sourced from twisted's releases.

Twisted 22.1.0 (2022-02-03)

Features

  • Python 3.10 is now a supported platform (#10224)
  • Type annotations have been added to the twisted.python.fakepwd module. (#10287)

Bugfixes

  • twisted.internet.defer.inlineCallbacks has an improved type annotation, to avoid typing errors when it is used on a function which returns a non-None result. (#10231)
  • twisted.internet.base.DelayedCall.__repr__ and twisted.internet.task.LoopingCall.__repr__ had the changes from #10155 reverted to accept non-function callables. (#10235)
  • Revert the removal of .whl building that was done as part of #10177. (#10236)
  • The type annotation of the host parameter to twisted.internet.interfaces.IReactorTCP.connectTCP has been corrected from bytes to str. (#10251)
  • Deprecated twisted.python.threading.ThreadPool.currentThread() in favor of threading.current_thread(). Switched twisted.python.threading.ThreadPool.currentThread() and twisted.python.threadable.getThreadID() to use `threading.current_thread()to avoid the deprecation warnings introduced forthreading.currentThread()`` in Python 3.10. (#10273)

Improved Documentation

  • twisted.internet.utils.runWithWarningsSupressed behavior of waiting on deferreds has been documented. (#10238)
  • Sync API docs templates with pydoctor 21.9.0 release, using new theming capabilities. (#10267)

Misc

Conch

Features


- twisted.conch.ssh now supports SSH extension negotiation (RFC 8308). ([#10266](https://github.com/twisted/twisted/issues/10266))

Bugfixes

  • twisted.conch now uses constant-time comparisons for MACs. (#8199)
  • twisted.conch.ssh.filetransfer.FileTransferServer will now return an ENOENT error status if an SFTP client tries to close an unrecognized file handle. (#10293)
  • SSHTransportBase.ssh_KEXINIT now uses the remote peer preferred MAC list for negotiation. In previous versions it was only using the local preferred MAC list. (#10241)

... (truncated)

Changelog

Sourced from twisted's changelog.

Twisted 22.1.0 (2022-02-03)

Features

  • Python 3.10 is now a supported platform (#10224)
  • Type annotations have been added to the twisted.python.fakepwd module. (#10287)

Bugfixes

  • twisted.internet.defer.inlineCallbacks has an improved type annotation, to avoid typing errors when it is used on a function which returns a non-None result. (#10231)
  • twisted.internet.base.DelayedCall.__repr__ and twisted.internet.task.LoopingCall.__repr__ had the changes from #10155 reverted to accept non-function callables. (#10235)
  • Revert the removal of .whl building that was done as part of #10177. (#10236)
  • The type annotation of the host parameter to twisted.internet.interfaces.IReactorTCP.connectTCP has been corrected from bytes to str. (#10251)
  • Deprecated twisted.python.threading.ThreadPool.currentThread() in favor of threading.current_thread(). Switched twisted.python.threading.ThreadPool.currentThread() and twisted.python.threadable.getThreadID() to use `threading.current_thread()to avoid the deprecation warnings introduced forthreading.currentThread()`` in Python 3.10. (#10273)

Improved Documentation

  • twisted.internet.utils.runWithWarningsSupressed behavior of waiting on deferreds has been documented. (#10238)
  • Sync API docs templates with pydoctor 21.9.0 release, using new theming capabilities. (#10267)

Misc

Conch

Bugfixes

  • SSHTransportBase.ssh_KEXINIT now uses the remote peer preferred MAC list for negotiation. In previous versions it was only using the local preferred MAC list. (#10241)

Features


- twisted.conch.ssh now supports SSH extension negotiation (RFC 8308). ([#10266](https://github.com/twisted/twisted/issues/10266))

Bugfixes </tr></table>

... (truncated)

Commits
  • 45d463c move conch bugfix.
  • d48e4d3 Manually update the release version and date inside the NEWS file. T
  • 9ce5061 Update final release version.
  • 9d9322b Update the release notes.
  • 7e65fbe Bump copyright.
  • ddf72a9 tox -e towncrier
  • b33589f Update to 21.1.0.rc1
  • a033c84 Merge pull request #1685 from twisted/10293-conch-sftp-close-invalid-handle
  • 9e9cce2 Copy the skip logic from FileTransferCloseTests
  • 385e9f2 mention the name of the draft doc
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #236 (13f4754) into master (fdaaabe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files         107      107           
  Lines        4767     4767           
  Branches      272      272           
=======================================
  Hits         4501     4501           
  Misses        223      223           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c88ae...13f4754. Read the comment docs.

Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Twisted is great, and I love Twisted, and we should keep Twisted great.

@jchristgit
Copy link
Collaborator

@thebeanogamer please enable regular merge commit merges. We are losing history

@jchristgit
Copy link
Collaborator

cc @david-cooke

@0xAda
Copy link
Contributor

0xAda commented Feb 11, 2022

I've reenabled merge commit & rebase merges, not sure why they were disabled again

@0xAda
Copy link
Contributor

0xAda commented Feb 11, 2022

I'm a little skeptical of merging this immediately, I'd like to check it runs with twisted 22.1.0 first, we've had some issues with twisted crashing on launch in the past

@jchristgit
Copy link
Collaborator

Thank you Ada for taking a look. Out of curiosity, why do we have twisted in our direct dependencies, if it's only a transitive dependency of daphne?

@0xAda
Copy link
Contributor

0xAda commented Feb 11, 2022

@jerbob

@jchristgit
Copy link
Collaborator

Hello @jerbob, could you please inform us about this matter?

@jerbob
Copy link
Member

jerbob commented Feb 11, 2022

A bug in twisted meant we had to downgrade our version until it was patched (core workers were failing to start). Not entirely sure if it's been patched yet but I can check today.

@thebeanogamer
Copy link
Member

Can we please merge #239 before this, so we can automatically test if this change will work.

@jchristgit
Copy link
Collaborator

jchristgit commented Feb 12, 2022 via email

Bumps [twisted](https://github.com/twisted/twisted) from 20.3.0 to 22.1.0.
- [Release notes](https://github.com/twisted/twisted/releases)
- [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst)
- [Commits](twisted/twisted@twisted-20.3.0...twisted-22.1.0)

---
updated-dependencies:
- dependency-name: twisted
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@thebeanogamer thebeanogamer force-pushed the dependabot/pip/twisted-22.1.0 branch from 0ba0d2b to 13f4754 Compare February 13, 2022 16:16
@thebeanogamer thebeanogamer enabled auto-merge (squash) February 13, 2022 16:21
@thebeanogamer thebeanogamer merged commit 9e780b6 into master Feb 13, 2022
@thebeanogamer thebeanogamer deleted the dependabot/pip/twisted-22.1.0 branch February 13, 2022 16:21
0xAda pushed a commit that referenced this pull request Sep 26, 2024
Bumps [twisted](https://github.com/twisted/twisted) from 20.3.0 to 22.1.0.
- [Release notes](https://github.com/twisted/twisted/releases)
- [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst)
- [Commits](twisted/twisted@twisted-20.3.0...twisted-22.1.0)

---
updated-dependencies:
- dependency-name: twisted
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants