-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump twisted from 20.3.0 to 22.1.0 #236
Conversation
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 107 107
Lines 4767 4767
Branches 272 272
=======================================
Hits 4501 4501
Misses 223 223
Partials 43 43 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, Twisted is great, and I love Twisted, and we should keep Twisted great.
@thebeanogamer please enable regular merge commit merges. We are losing history |
cc @david-cooke |
I've reenabled merge commit & rebase merges, not sure why they were disabled again |
I'm a little skeptical of merging this immediately, I'd like to check it runs with twisted 22.1.0 first, we've had some issues with twisted crashing on launch in the past |
Thank you Ada for taking a look. Out of curiosity, why do we have twisted in our direct dependencies, if it's only a transitive dependency of daphne? |
Hello @jerbob, could you please inform us about this matter? |
A bug in twisted meant we had to downgrade our version until it was patched (core workers were failing to start). Not entirely sure if it's been patched yet but I can check today. |
Can we please merge #239 before this, so we can automatically test if this change will work. |
Daniel, I agree. Thanks for your initiative.
… Am 12.02.2022 um 21:23 schrieb Daniel Milnes ***@***.***>:
Can we please merge #239 before this, so we can automatically test if this change will work.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.
|
Bumps [twisted](https://github.com/twisted/twisted) from 20.3.0 to 22.1.0. - [Release notes](https://github.com/twisted/twisted/releases) - [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst) - [Commits](twisted/twisted@twisted-20.3.0...twisted-22.1.0) --- updated-dependencies: - dependency-name: twisted dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
0ba0d2b
to
13f4754
Compare
Bumps [twisted](https://github.com/twisted/twisted) from 20.3.0 to 22.1.0. - [Release notes](https://github.com/twisted/twisted/releases) - [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst) - [Commits](twisted/twisted@twisted-20.3.0...twisted-22.1.0) --- updated-dependencies: - dependency-name: twisted dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps twisted from 20.3.0 to 22.1.0.
Release notes
Sourced from twisted's releases.
... (truncated)
Changelog
Sourced from twisted's changelog.
... (truncated)
Commits
45d463c
move conch bugfix.d48e4d3
Manually update the release version and date inside the NEWS file. T9ce5061
Update final release version.9d9322b
Update the release notes.7e65fbe
Bump copyright.ddf72a9
tox -e towncrierb33589f
Update to 21.1.0.rc1a033c84
Merge pull request #1685 from twisted/10293-conch-sftp-close-invalid-handle9e9cce2
Copy the skip logic from FileTransferCloseTests385e9f2
mention the name of the draft docDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.