Add Integration Tests #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make clean-dev-server` will remove this
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 107 107
Lines 4767 4767
Branches 272 272
=======================================
Hits 4501 4501
Misses 223 223
Partials 43 43 Continue to review full report at Codecov.
|
GitHub Actions are weak
This reverts commit 0c923f5.
0xAda
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Persist the database in docker-compose `make clean-dev-server` will remove this * Add an integration test * Make curl fail * Generate some test fixtures * Wait longer for the boot GitHub Actions are weak * Do better shell redirects * 10 seconds is plenty * Try and set current working directory * Revert "Try and set current working directory" This reverts commit 0c923f5. * More escaping * Even more * Try removing a character * Spaces * IT NEARLY WORKS * Try no tty * Docker is bad * Set working directory for exec * Try less arguments * Force non interactive * Try a subshell * Use smaller fixtures * Make curl verbose * Bind to all interfaces * Test the makefile whilst we're here * Change test names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds integrations tests in GitHub Actions, which perform the following:
make fake-datato generate some test fixtures/stats/stats/endpoint worksTo do this, I've had to add a persistent database to the
postgrescontainer, but I've updated theclean-dev-servermakefile target to clean this up. This is tested within the workflow.This should hopefully catch things like us writing broken migrations or updating things like twisted which prevent core from booting.
Resolves #238