Fixed ptrace 'Operation not permitted' #15287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess; cleaned up the code
radare
reviewed
Oct 16, 2019
| // Attaching to a process that has already been started with PTRACE_TRACEME. | ||
| // sets errno to "Operation not permitted" which may be misleading. | ||
| // GETSIGINFO can be called multiple times and would fail without attachment. | ||
| if (-1 == r_debug_ptrace(dbg, PTRACE_GETSIGINFO, ptid, NULL, |
There was a problem hiding this comment.
missing space before ( and piut the == -1 in the right side of the statement
radare
reviewed
Oct 16, 2019
| // GETSIGINFO can be called multiple times and would fail without attachment. | ||
| if (-1 == r_debug_ptrace(dbg, PTRACE_GETSIGINFO, ptid, NULL, | ||
| (r_ptrace_data_t)&sig)) { | ||
| if (-1 == r_debug_ptrace (dbg, PTRACE_ATTACH, ptid, NULL, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is a result of running PT_ATTACH on a forked PID when you're only supposed to PT_ATTACH remote pids. linux_set_options probably always worked for you when testing in fork mode but it wouldn't work in remote attachment since you have to attach first + there's was error handling there.
When using fork_and_ptraceme_for_linux the child sets himself up to be traced for you.
I used GETSIGINFO to check the attachment status since it doesn't have any consequences(same result even if you run it multiple times) and always works on an attached process.
Also went ahead and cleaned up the code around the changes.
closes #14506