Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ptrace 'Operation not permitted' #15287

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Fixed ptrace 'Operation not permitted' #15287

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b9f3b2
Fixed ptrace errors by avoiding attaching to an already attached proc…
yossizap Oct 16, 2019
41cd5c9
Fixed formatting
yossizap Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 26 additions & 18 deletions libr/debug/p/native/linux/linux_debug.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@ char *linux_reg_profile (RDebug *dbg) {

static void linux_detach_all (RDebug *dbg);
static char *read_link (int pid, const char *file);
static int linux_attach_single_pid (RDebug *dbg, int ptid);
static bool linux_attach_single_pid (RDebug *dbg, int ptid);
static void linux_attach_all (RDebug *dbg);
static void linux_remove_thread (RDebug *dbg, int pid);
static void linux_add_and_attach_new_thread (RDebug *dbg, int tid);
static int linux_stop_process(int pid);

int linux_handle_signals (RDebug *dbg) {
siginfo_t siginfo = {0};
siginfo_t siginfo = { 0 };
int ret = r_debug_ptrace (dbg, PTRACE_GETSIGINFO, dbg->pid, 0, (r_ptrace_data_t)(size_t)&siginfo);
if (ret == -1) {
/* ESRCH means the process already went away :-/ */
Expand Down Expand Up @@ -243,6 +243,7 @@ bool linux_set_options(RDebug *dbg, int pid) {
/* SIGTRAP | 0x80 on signal handler .. not supported on all archs */
traceflags |= PTRACE_O_TRACESYSGOOD;
if (r_debug_ptrace (dbg, PTRACE_SETOPTIONS, pid, 0, (r_ptrace_data_t)(size_t)traceflags) == -1) {
perror ("ptrace (PT_SETOPTIONS)");
return false;
}
return true;
Expand Down Expand Up @@ -408,10 +409,26 @@ static int linux_stop_process(int pid) {
return ret == pid;
}

static int linux_attach_single_pid(RDebug *dbg, int ptid) {
linux_set_options (dbg, ptid);
return r_debug_ptrace (dbg, PTRACE_ATTACH, ptid, NULL,
(r_ptrace_data_t)(size_t)NULL);
static bool linux_attach_single_pid(RDebug *dbg, int ptid) {
siginfo_t sig = {0};
// Safely check if the PID has already been attached to avoid printing errors.
// Attaching to a process that has already been started with PTRACE_TRACEME.
// sets errno to "Operation not permitted" which may be misleading.
// GETSIGINFO can be called multiple times and would fail without attachment.
if (-1 == r_debug_ptrace(dbg, PTRACE_GETSIGINFO, ptid, NULL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space before ( and piut the == -1 in the right side of the statement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

(r_ptrace_data_t)&sig)) {
if (-1 == r_debug_ptrace (dbg, PTRACE_ATTACH, ptid, NULL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

(r_ptrace_data_t)NULL)) {
perror ("ptrace (PT_ATTACH)");
return false;
}
}

if (!linux_set_options (dbg, ptid)) {
return false;
}

return true;
}

static RList *get_pid_thread_list (RDebug *dbg, int main_pid) {
Expand All @@ -424,21 +441,16 @@ static RList *get_pid_thread_list (RDebug *dbg, int main_pid) {
}

static void linux_attach_all (RDebug *dbg) {
int ret = linux_attach_single_pid (dbg, dbg->main_pid);
if (ret != -1) {
perror ("ptrace (PT_ATTACH)");
}
linux_attach_single_pid (dbg, dbg->main_pid);

RList *list = dbg->threads;
if (list) {
RDebugPid *th;
RListIter *it;
r_list_foreach (list, it, th) {
if (th->pid && th->pid != dbg->main_pid) {
ret = linux_attach_single_pid (dbg, th->pid);
if (ret == -1) {
if (!linux_attach_single_pid (dbg, th->pid)) {
eprintf ("PID %d\n", th->pid);
perror ("ptrace (PT_ATTACH)");
}
}
}
Expand All @@ -456,10 +468,7 @@ int linux_attach(RDebug *dbg, int pid) {
if (dbg->threads && !r_list_find (dbg->threads, &pid, &match_pid)) {
goto out;
}
int ret = linux_attach_single_pid (dbg, pid);
if (ret == -1) {
perror ("ptrace (PT_ATTACH)");
}
linux_attach_single_pid (dbg, pid);
}
out:
return pid;
Expand Down Expand Up @@ -881,7 +890,6 @@ int linux_reg_read(RDebug *dbg, int type, ut8 *buf, int size) {
ret = r_debug_ptrace (dbg, PTRACE_GETREGS, pid, &regs, NULL);
#else
/* linux -{arm/mips/riscv/x86/x86_64} */
eprintf ("REG READ\n");
ret = r_debug_ptrace (dbg, PTRACE_GETREGS, pid, NULL, &regs);
#endif
/*
Expand Down
39 changes: 24 additions & 15 deletions libr/io/p/io_ptrace.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,19 @@ static bool __plugin_open(RIO *io, const char *file, bool many) {
static RIODesc *__open(RIO *io, const char *file, int rw, int mode) {
RIODesc *desc = NULL;
int ret = -1;
if (__plugin_open (io, file, 0)) {
int pid = atoi (file + 9);
// ret = r_io_ptrace (io, PTRACE_ATTACH, pid, 0, 0);
siginfo_t sig = { 0 };

if (!__plugin_open (io, file, 0)) {
return NULL;
}

int pid = atoi (file + 9);

// Safely check if the PID has already been attached to avoid printing errors.
ret = r_io_ptrace (io, PTRACE_GETSIGINFO, pid, NULL, &sig);
// Attempt attaching on failure
if (-1 == ret) {
ret = r_io_ptrace (io, PTRACE_ATTACH, pid, 0, 0);
if (file[0] == 'p') { //ptrace
ret = 0;
} else
if (ret == -1) {
#ifdef __ANDROID__
eprintf ("ptrace_attach: Operation not permitted\n");
Expand All @@ -208,17 +214,20 @@ static RIODesc *__open(RIO *io, const char *file, int rw, int mode) {
} else {
eprintf ("Error in waitpid\n");
}
if (ret != -1) {
RIOPtrace *riop = R_NEW0 (RIOPtrace);
if (!riop) {
return NULL;
}
riop->pid = riop->tid = pid;
open_pidmem (riop);
desc = r_io_desc_new (io, &r_io_plugin_ptrace, file, rw | R_PERM_X, mode, riop);
desc->name = r_sys_pid_to_path (pid);
}

if (ret != -1) {
RIOPtrace *riop = R_NEW0 (RIOPtrace);
if (!riop) {
return NULL;
}

riop->pid = riop->tid = pid;
open_pidmem (riop);
desc = r_io_desc_new (io, &r_io_plugin_ptrace, file, rw | R_PERM_X, mode, riop);
desc->name = r_sys_pid_to_path (pid);
}

return desc;
}

Expand Down