update add radius to existing app tutorial #1053
Conversation
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
| @@ -258,7 +258,7 @@ You will now add Radius to the Guestbook application's Kubernetes deployment man | |||
| Now that Radius has been enabled for your application, run this command again: | |||
|
|
|||
| ```bash | |||
| rad app connections -a demo | |||
| rad app graph -a demo -g default-demo | |||
There was a problem hiding this comment.
Shd we change rad app connections to rad app graph in all the docs that references connection ? I don't see a CLI reference page for rad app graph in our docs.
There was a problem hiding this comment.
even though it's a bit beyond the scope of this PR, I agree with your observation and committed a "rebrand" of rad app connections to rad app graph -- please take a look.
There was a problem hiding this comment.
The CLI reference pages shouldn't be manually edited. We can't update these until we complete the migration of the CLI code from connections to graph
There was a problem hiding this comment.
I think its better to update this once rebranding feature is complete ?
Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
willtsai
changed the title
rad app connections to rad app graph
There was a problem hiding this comment.
this page is autogenerated and shouldn't be edited directly
There was a problem hiding this comment.
got it, I will remove the edits from this pr. how do we go about making it auto-generate rad app graph instead of connections?
There was a problem hiding this comment.
We'll need to complete the implementation of radius-project/radius#6473
There was a problem hiding this comment.
got it, reverted the "rebranding" changes.
There was a problem hiding this comment.
This page is autogenerated and shouldn't be edited directly
willtsai
changed the title
rad app connections to rad app graphSigned-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Update the "Add Radius to an existing application" tutorial to use images in our own Radius container registry and also update the commands use to see the Radius app graph and connections.
Issue reference
Fixes: radius-project/samples#914
Related: radius-project/samples#986