Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update add radius to existing app tutorial #1053

Merged
merged 3 commits into from
Feb 22, 2024
Merged

update add radius to existing app tutorial #1053

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f797caa
update add radius to existing app tutorial
willtsai Feb 22, 2024
745fcbb
rebrand rad app connections to rad app graph
willtsai Feb 22, 2024
126755b
undo rebrand rad app connections to rad app graph
willtsai Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions docs/content/tutorials/tutorial-add-radius/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,15 @@ Step 2: Deploy and test the existing Guestbook application using `kubectl`
Run this command to view the state of your application using Radius:

```bash
rad app connections -a demo
rad app graph -a demo -g default-demo
```

Since you have not yet added Radius to the application, the `rad` CLI will not recognize your `demo` application and you should see a message in the output similar to:

```
Application "demo" does not exist or has been deleted.
Displaying application: demo

(empty)
```

## Step 3: Add Radius to the Guestbook application
Expand Down Expand Up @@ -175,9 +177,9 @@ You will now add Radius to the Guestbook application's Kubernetes deployment man
apiVersion: apps/v1 # for k8s versions before 1.9.0 use apps/v1beta2 and before 1.8.0 use extensions/v1beta1
kind: Deployment
metadata:
name: frontend
annotations:
rad.app/enabled: 'true'
name: frontend
annotations:
rad.app/enabled: 'true'
spec:
selector:
matchLabels:
Expand All @@ -192,7 +194,7 @@ You will now add Radius to the Guestbook application's Kubernetes deployment man
spec:
containers:
- name: php-redis
image: gcr.io/google-samples/gb-frontend:v4
image: ghcr.io/radius-project/samples/gb-frontend:v4
resources:
requests:
cpu: 100m
Expand Down Expand Up @@ -258,7 +260,7 @@ You will now add Radius to the Guestbook application's Kubernetes deployment man
Now that Radius has been enabled for your application, run this command again:

```bash
rad app connections -a demo
rad app graph -a demo -g default-demo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shd we change rad app connections to rad app graph in all the docs that references connection ? I don't see a CLI reference page for rad app graph in our docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though it's a bit beyond the scope of this PR, I agree with your observation and committed a "rebrand" of rad app connections to rad app graph -- please take a look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CLI reference pages shouldn't be manually edited. We can't update these until we complete the migration of the CLI code from connections to graph

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its better to update this once rebranding feature is complete ?

```

You should see output containing information and status of your newly "radified" application, similar to:
Expand Down
Loading