-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HowTo tutorial to configure Terraform Custom Provider #1162
Add HowTo tutorial to configure Terraform Custom Provider #1162
Conversation
5d9710c
to
3b49a12
Compare
3b49a12
to
b492f4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall flow looks good. Suggested some edits for clarity.
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
|
||
This how-to guide will describe how to: | ||
|
||
- Configure a custom Terraform Provider and use it in a Terraform recipe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Configure a custom Terraform Provider and use it in a Terraform recipe. | |
- Configure a custom [Terraform provider](https://registry.terraform.io/browse/providers) in a Radius environment | |
- Consume the terraform modules from a custom Terraform provider and use it in a Terraform recipe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there also be a bullet point indicating that they will configure credentials for the terraform provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added. pls take another look.
This how-to guide will describe how to: | ||
|
||
- Configure a custom Terraform Provider and use it in a Terraform recipe. | ||
In this example we're going to configure a PostgreSQL Terraform provider in a Radius environment and deploy a recipe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this example we're going to configure a PostgreSQL Terraform provider in a Radius environment and deploy a recipe. | |
In this example we're going to configure a [PostgreSQL Terraform provider](https://registry.terraform.io/providers/cyrilgdn/postgresql/latest/docs) in a Radius environment and deploy a recipe. |
Suggest adding the reference link here and remove the next line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. pls take another look
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
|
||
This how-to guide will describe how to: | ||
|
||
- Configure a custom Terraform Provider and use it in a Terraform recipe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there also be a bullet point indicating that they will configure credentials for the terraform provider?
|
||
{{< rad file="snippets/env.bicep" embed=true marker="//SECRETSTORE" >}} | ||
|
||
> In this example, we're creating a secret with keys `username` and `password` as sensitive inputs required by the Terraform Provider `cyrilgdn/postgresql`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also explain what exactly this "sensitive data" is used for? I'm assuming it's to authenticate into the postgresql provider but would be good to clarify and maybe even link to any of their documentation on authentication.
> In this example, we're creating a secret with keys `username` and `password` as sensitive inputs required by the Terraform Provider `cyrilgdn/postgresql`. | |
> In this example, we're creating a secret with keys `username` and `password` as sensitive data required by the Terraform Provider `cyrilgdn/postgresql`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. pls take a look. The link for official provider documentation is there in the beginning of the page. I'm not sure if we want to copy it over again here. let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to repeat, i think indicating that it's for auth is good enough
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
``` | ||
rad deploy ./env.bicep -p username=****** -p password=****** | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a note here explaining what username and password fields the reader needs to pass into this command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a note. Pls take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, this looks good!
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
@lakshmimsft - Can you target the PR to v0.36 ? I'll close this and create new PR after comments are addressed. Is that okay? |
c546958
to
63ea5d8
Compare
63ea5d8
to
6730150
Compare
6730150
to
8c70459
Compare
8c70459
to
60f1566
Compare
60f1566
to
161a733
Compare
161a733
to
150c991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some additional corrections i missed earlier
``` | ||
rad deploy ./env.bicep -p username=****** -p password=****** | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, this looks good!
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved from my side, but might want @Reshrahim to take a look as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Have a small suggestion
docs/content/guides/recipes/terraform/howto-custom-provider/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
* add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com>
* Update docs for v0.36.0 Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update auto-generated documentation (#1151) * Autogenerate reference docs Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> * Update en-custom.txt Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> --------- Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Add HowTo tutorial to configure Terraform Custom Provider (#1162) * add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * correct highlight (#1164) Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update index.md (#1160) Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Add envSecrets block to HowTo Custom Provider tutorial (#1166) * adding envSecrets * updated per suggestion Signed-off-by: sk593 <shruthikumar@microsoft.com> * removing port input in config (#1167) Signed-off-by: sk593 <shruthikumar@microsoft.com> * revert Signed-off-by: sk593 <shruthikumar@microsoft.com> * fix spellcheck Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update docs/layouts/partials/hooks/body-end.html Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> --------- Signed-off-by: sk593 <shruthikumar@microsoft.com> Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> Co-authored-by: rad-ci-bot <103787451+rad-ci-bot@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
* Update docs for v0.36.0 * Update auto-generated documentation (#1151) * Autogenerate reference docs Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> * Update en-custom.txt Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> --------- Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> * Add HowTo tutorial to configure Terraform Custom Provider (#1162) * add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> * correct highlight (#1164) * Update index.md (#1160) Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> * Add envSecrets block to HowTo Custom Provider tutorial (#1166) * adding envSecrets * updated per suggestion * removing port input in config (#1167) * Fix upmerge workflow error when no changes (#1192) Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> * addressing comments Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com> * addressing comments Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com> --------- Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com> Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> Co-authored-by: rad-ci-bot <103787451+rad-ci-bot@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Adding HowTo tutorial to configure Terraform Custom Provider
6539