Remove port in provider config HowTo Custom Provider #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reshrahim
approved these changes
Jul 29, 2024
sk593
pushed a commit
that referenced
this pull request
Aug 7, 2024
sk593
pushed a commit
that referenced
this pull request
Aug 7, 2024
Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593
added a commit
that referenced
this pull request
Aug 13, 2024
* Update docs for v0.36.0 Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update auto-generated documentation (#1151) * Autogenerate reference docs Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> * Update en-custom.txt Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> --------- Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Add HowTo tutorial to configure Terraform Custom Provider (#1162) * add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * correct highlight (#1164) Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update index.md (#1160) Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: sk593 <shruthikumar@microsoft.com> * Add envSecrets block to HowTo Custom Provider tutorial (#1166) * adding envSecrets * updated per suggestion Signed-off-by: sk593 <shruthikumar@microsoft.com> * removing port input in config (#1167) Signed-off-by: sk593 <shruthikumar@microsoft.com> * revert Signed-off-by: sk593 <shruthikumar@microsoft.com> * fix spellcheck Signed-off-by: sk593 <shruthikumar@microsoft.com> * Update docs/layouts/partials/hooks/body-end.html Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> --------- Signed-off-by: sk593 <shruthikumar@microsoft.com> Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> Co-authored-by: rad-ci-bot <103787451+rad-ci-bot@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com>
Reshrahim
added a commit
that referenced
this pull request
Aug 16, 2024
* Update docs for v0.36.0 * Update auto-generated documentation (#1151) * Autogenerate reference docs Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> * Update en-custom.txt Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> --------- Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> * Add HowTo tutorial to configure Terraform Custom Provider (#1162) * add howto doc for tf custom provider config * unsaved files * update per comments * update for conflicts * extra space * extra space * further comments * capitalizing Environment * one more change --------- Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> * correct highlight (#1164) * Update index.md (#1160) Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> * Add envSecrets block to HowTo Custom Provider tutorial (#1166) * adding envSecrets * updated per suggestion * removing port input in config (#1167) * Fix upmerge workflow error when no changes (#1192) Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> * addressing comments Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com> * addressing comments Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com> --------- Signed-off-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Signed-off-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Signed-off-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Signed-off-by: Vishwanath Hiremath <vhiremath@microsoft.com> Co-authored-by: Radius CI Bot <radiuscoreteam@service.microsoft.com> Co-authored-by: rad-ci-bot <103787451+rad-ci-bot@users.noreply.github.com> Co-authored-by: rad-ci-bot <rad-ci-bot@users.noreply.github.com> Co-authored-by: Reshma Abdul Rahim <61033581+Reshrahim@users.noreply.github.com> Co-authored-by: Lakshmi Javadekar <103459615+lakshmimsft@users.noreply.github.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Port is passed in as an environment variable in this example. The change is to update one of the bicep files which has port both in provider config and as environment variable. Although the bicep still deploys successfully, we're removing this from the provider config as it's not needed.