Installing the Dapr Helm Chart via the CLI #8033

superbeeny · 2024-11-05T17:50:02Z

Description

Installing the Dapr Helm Chart via the CLI

Type of change

This pull request adds a feature to install Dapr to its own namespace by using the rad cli.

Fixes: #8032

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
[ N/R ] A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
[ N/R ] A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
[ N/R ] A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

pkg/cli/cmd/radinit/cluster.go

bicep-types

ytimocin · 2024-11-06T20:23:59Z

pkg/cli/cmd/radinit/cluster.go

@@ -39,11 +39,11 @@ func (r *Runner) enterClusterOptions(options *initOptions) error {
 	if err != nil {
 		return clierrors.MessageWithCause(err, "Unable to verify Radius installation.")
 	}
-	options.Cluster.Install = !state.Installed
+	options.Cluster.Install = !state.RadiusInstalled || !state.DaprInstalled


Should we add a test for this new case?

pkg/cli/cmd/uninstall/kubernetes/kubernetes.go

pkg/cli/helm/cluster.go

ytimocin · 2024-11-06T20:27:35Z

pkg/cli/helm/cluster.go

-// CheckRadiusInstall checks if the Radius release is installed in the given kubeContext and returns an InstallState object
-// with the version of the release if installed, or an error if an error occurs while checking.
-func CheckRadiusInstall(kubeContext string) (InstallState, error) {
+// QueryRelease checks to see if a release is deployed to a namespace for a given kubecontext.


nit

Suggested change

// QueryRelease checks to see if a release is deployed to a namespace for a given kubecontext.

// queryRelease checks to see if a release is deployed to a namespace for a given kubecontext.

What are the 3 outputs of this function? Can we add a doc for that too?

ytimocin · 2024-11-06T20:28:43Z

pkg/cli/helm/cluster.go

+// CheckRadiusInstall checks if the Radius release is installed in the given kubeContext and returns an InstallState object
+// with the version of the release if installed, or an error if an error occurs while checking.
+func CheckRadiusInstall(kubeContext string) (InstallState, error) {
+


nit: extra line can be removed

pkg/cli/helm/cluster.go

superbeeny · 2024-11-07T20:53:53Z

After some discussion with @rynowak and a review of the current codebase where contour is uninstalled we agreed to be consistent and uninstall dapr

rynowak · 2024-11-07T20:57:46Z

After some discussion with @rynowak and a review of the current codebase where contour is uninstalled we agreed to be consistent and uninstall dapr

Yes 👍. I was under the impression that we left Contour alone during uninstall. It turns out we remove it.

@superbeeny and I made the executive decision to be consistent with our existing behavior in the absence of user feedback. Both options (leave-installed, uninstall) have downsides. If we get feedback we'll change this.

I'll remind everyone that rad uninstall is provided for convenience, and so we're optimizing for convenience. We expect users to use the Helm charts directly in more serious scenarios.

rynowak

Changes look good to me 👍 We should merge this now that we've branched for 0.39. We will be layering other changes on top for 0.40.

radius-functional-tests · 2024-11-10T21:44:46Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`9b6aaa2`
Unique ID	func8e15f50698
Image tag	pr-func8e15f50698

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8e15f50698
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8e15f50698
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func8e15f50698
controller test image location: ghcr.io/radius-project/dev/controller:pr-func8e15f50698
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8e15f50698
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-11-15T23:58:02Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`9ec2ba0`
Unique ID	funcd9a78759d6
Image tag	pr-funcd9a78759d6

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd9a78759d6
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd9a78759d6
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcd9a78759d6
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd9a78759d6
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd9a78759d6
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

ytimocin · 2024-11-18T05:41:40Z

These workflows may need to be tested/updated since Dapr is installed via Helm in those.

I see some functional tests of this PR fail at the Install Radius step: https://github.com/radius-project/radius/actions/runs/11865183744/job/33070281563?pr=8033.

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

radius-functional-tests · 2024-11-18T17:34:12Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`2a1affb`
Unique ID	func86a0238e2b
Image tag	pr-func86a0238e2b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func86a0238e2b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func86a0238e2b
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func86a0238e2b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func86a0238e2b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func86a0238e2b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

superbeeny · 2024-11-18T20:48:00Z

workflows

My first guess is that we're not detecting that dapr is already installed, should be easy enough to replicate ... thanks!!

radius-functional-tests · 2024-11-18T21:49:17Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`ebdce15`
Unique ID	func73d63c4ef9
Image tag	pr-func73d63c4ef9

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func73d63c4ef9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func73d63c4ef9
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func73d63c4ef9
controller test image location: ghcr.io/radius-project/dev/controller:pr-func73d63c4ef9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func73d63c4ef9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

radius-functional-tests · 2024-11-20T15:34:02Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`52d0fd5`
Unique ID	funcc2cdefd152
Image tag	pr-funcc2cdefd152

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc2cdefd152
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc2cdefd152
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc2cdefd152
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc2cdefd152
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc2cdefd152
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

rynowak · 2024-11-21T02:29:23Z

.github/workflows/functional-test-cloud.yaml

+      # - name: Install dapr into cluster
+      #   run: |
+      #     wget -q https://raw.githubusercontent.com/dapr/cli/master/install/install.sh -O - | /bin/bash -s ${{ env.DAPR_VER }}
+      #     dapr init -k --wait --timeout 600 --runtime-version ${{ env.DAPR_VER }} --dashboard-version ${{ env.DAPR_DASHBOARD_VER }}


Hey @superbeeny - I have a question about removing this.

Does rad install kubernetes install fail when Dapr is already installed? I think we should make sure that case succeeds.

I'm trying to assess whether this is being removed because it's unnecessary, or whether it's being removed because it's broken.

Also I'd prefer this be deleted rather than commented out. As well as the env-vars if they are unused. We have source control to see the history 👍

We can resolve that after the question above ^^^.

Rad init will not fail for an existing dapr install

rynowak · 2024-11-21T02:32:11Z

pkg/cli/helm/cluster.go

 	if err != nil {
 		return false, err
 	}

-	err = ApplyContourHelmChart(options.Contour, kubeContext)
+	// Install Dapr
+	daprFound, err := ApplyHelmChart(clusterOptions.Dapr, kubeContext)


Per this question, we might need an "if !(Dapr is installed)" here.

rynowak

One more question here: https://github.com/radius-project/radius/pull/8033/files#r1851230293

I think this is almost ready to go.

…bbreviations (radius-project#8073) # Description Updated cmd line functions to use `environment` in place of `env` and `initialize` in place of `init`. Both abbreviations are now aliased so this is a non breaking change. ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). Fixes: radius-project#8043 Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

rynowak

- this is awesome! thanks @superbeeny

radius-functional-tests · 2024-11-21T19:49:26Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	`7415793`
Unique ID	func98ed316fec
Image tag	pr-func98ed316fec

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func98ed316fec
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func98ed316fec
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func98ed316fec
controller test image location: ghcr.io/radius-project/dev/controller:pr-func98ed316fec
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func98ed316fec
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

superbeeny requested review from a team as code owners November 5, 2024 17:50

ytimocin reviewed Nov 6, 2024

View reviewed changes

pkg/cli/cmd/radinit/cluster.go Show resolved Hide resolved

ytimocin reviewed Nov 6, 2024

View reviewed changes

rynowak reviewed Nov 7, 2024

View reviewed changes

pkg/cli/helm/cluster.go Outdated Show resolved Hide resolved

superbeeny force-pushed the features/superbeeny/dapr-install branch from a3bbec4 to 2e640bb Compare November 7, 2024 20:51

superbeeny temporarily deployed to publish-bicep November 7, 2024 20:51 — with GitHub Actions Inactive

rynowak temporarily deployed to publish-bicep November 10, 2024 21:38 — with GitHub Actions Inactive

rynowak previously approved these changes Nov 10, 2024

View reviewed changes

rynowak temporarily deployed to functional-tests November 10, 2024 21:43 — with GitHub Actions Inactive

ytimocin force-pushed the features/superbeeny/dapr-install branch from 9b6aaa2 to 9bc827a Compare November 11, 2024 17:45

ytimocin temporarily deployed to publish-bicep November 11, 2024 17:45 — with GitHub Actions Inactive

superbeeny temporarily deployed to publish-bicep November 12, 2024 13:07 — with GitHub Actions Inactive

ytimocin temporarily deployed to publish-bicep November 15, 2024 23:53 — with GitHub Actions Inactive

ytimocin temporarily deployed to functional-tests November 15, 2024 23:57 — with GitHub Actions Inactive

superbeeny added 5 commits November 18, 2024 10:14

WIP: Implementing Dapr install for radius

224cb67

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

working commit

7e253ba

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

fixing options initialization

c3a77b4

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

adding default value to options

8da628a

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

fixing the install tests

2a1affb

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

superbeeny dismissed rynowak’s stale review via 2a1affb November 18, 2024 15:14

superbeeny force-pushed the features/superbeeny/dapr-install branch from 9ec2ba0 to 2a1affb Compare November 18, 2024 15:14

superbeeny temporarily deployed to publish-bicep November 18, 2024 15:14 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests November 18, 2024 17:33 — with GitHub Actions Inactive

fixing last unit test

ebdce15

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

superbeeny temporarily deployed to publish-bicep November 18, 2024 20:34 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests November 18, 2024 21:48 — with GitHub Actions Inactive

commenting out dapr install in functional tests

a4df5b7

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

superbeeny temporarily deployed to publish-bicep November 20, 2024 14:50 — with GitHub Actions Inactive

Merge branch 'main' into features/superbeeny/dapr-install

52d0fd5

superbeeny temporarily deployed to publish-bicep November 20, 2024 14:53 — with GitHub Actions Inactive

superbeeny temporarily deployed to functional-tests November 20, 2024 15:33 — with GitHub Actions Inactive

rynowak reviewed Nov 21, 2024

View reviewed changes

superbeeny and others added 2 commits November 21, 2024 09:31

removing comments and adding version for dapr

56b19bb

Signed-off-by: Nick Beenham <Nicholas_Beenham@cable.comcast.com>

superbeeny temporarily deployed to publish-bicep November 21, 2024 16:29 — with GitHub Actions Inactive

Merge branch 'main' into features/superbeeny/dapr-install

7415793

superbeeny temporarily deployed to publish-bicep November 21, 2024 17:06 — with GitHub Actions Inactive

rynowak approved these changes Nov 21, 2024

View reviewed changes

superbeeny temporarily deployed to functional-tests November 21, 2024 19:48 — with GitHub Actions Inactive

rynowak merged commit 9650406 into radius-project:main Nov 21, 2024
28 checks passed

nithyatsu mentioned this pull request Dec 16, 2024

Investigate missing eks coverage in functional tests #8141

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installing the Dapr Helm Chart via the CLI #8033

Installing the Dapr Helm Chart via the CLI #8033

superbeeny commented Nov 5, 2024

ytimocin Nov 6, 2024

ytimocin Nov 6, 2024

ytimocin Nov 6, 2024

ytimocin Nov 6, 2024

superbeeny commented Nov 7, 2024

rynowak commented Nov 7, 2024

rynowak left a comment

radius-functional-tests bot commented Nov 10, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 15, 2024 •

edited

Loading

ytimocin commented Nov 18, 2024

radius-functional-tests bot commented Nov 18, 2024 •

edited

Loading

superbeeny commented Nov 18, 2024

radius-functional-tests bot commented Nov 18, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 20, 2024 •

edited

Loading

rynowak Nov 21, 2024

rynowak Nov 21, 2024

superbeeny Nov 21, 2024

rynowak Nov 21, 2024

superbeeny Nov 21, 2024

rynowak left a comment

rynowak left a comment

radius-functional-tests bot commented Nov 21, 2024 •

edited

Loading

	// QueryRelease checks to see if a release is deployed to a namespace for a given kubecontext.
	// queryRelease checks to see if a release is deployed to a namespace for a given kubecontext.

Installing the Dapr Helm Chart via the CLI #8033

Installing the Dapr Helm Chart via the CLI #8033

Conversation

superbeeny commented Nov 5, 2024

Description

Type of change

Contributor checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

superbeeny commented Nov 7, 2024

rynowak commented Nov 7, 2024

rynowak left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 10, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 15, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin commented Nov 18, 2024

radius-functional-tests bot commented Nov 18, 2024 • edited Loading

Radius functional test overview

Test Status

superbeeny commented Nov 18, 2024

radius-functional-tests bot commented Nov 18, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 20, 2024 • edited Loading

Radius functional test overview

Test Status

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rynowak left a comment

Choose a reason for hiding this comment

rynowak left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Nov 21, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Nov 10, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 15, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 18, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 18, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 20, 2024 •

edited

Loading

radius-functional-tests bot commented Nov 21, 2024 •

edited

Loading