Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] complete drop index stmt syntax with MySQL 8.0 #693

Closed
hustjieke opened this issue Oct 22, 2020 · 0 comments
Closed

[feature] complete drop index stmt syntax with MySQL 8.0 #693

hustjieke opened this issue Oct 22, 2020 · 0 comments
Assignees
@hustjieke
Labels
P0 High priority type: feature

Comments

@hustjieke
Copy link
Contributor

In 8.0, the drop index syntax:

DROP INDEX index_name ON tbl_name
    [algorithm_option | lock_option] ...

algorithm_option:
    ALGORITHM [=] {DEFAULT | INPLACE | COPY}

lock_option:
    LOCK [=] {DEFAULT | NONE | SHARED | EXCLUSIVE}

radon now support:

DROP INDEX index_name ON table_name

radon should add options after stmt.
@hustjieke hustjieke added type: feature P0 High priority labels Oct 22, 2020
@hustjieke hustjieke self-assigned this Oct 22, 2020
hustjieke added a commit to hustjieke/radon that referenced this issue Oct 26, 2020
@hustjieke
sqlparser: add drop index "lock | algorithm option" radondb#693
fc10792 
[summary]
1. Add drop index "lock | algorithm option".
2. Refactor lock_algorithm_option in create index.

[test case]
src/proxy/ddl_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ddl_test.go

[patch codecov]
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go       96.2%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast_funcs.go 95.4%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/sql.go       69.6%
hustjieke added a commit to hustjieke/radon that referenced this issue Nov 12, 2020
@hustjieke
docs: adjust format to make more clear radondb#693
2b1f5ad
hustjieke added a commit to hustjieke/radon that referenced this issue Nov 12, 2020
@hustjieke
sqlparser: move lock and algorithm option to ast_funcs.go radondb#693
e767925
hustjieke added a commit to hustjieke/radon that referenced this issue Nov 12, 2020
@hustjieke
sqlparser: move lock and algorithm option to ast_funcs.go radondb#693
c4de3c0
BohuTANG added a commit that referenced this issue Nov 12, 2020
@BohuTANG
Merge pull request #697 from hustjieke/feature_complete_drop_index_op…
4eb64ff 
…tion_#693

sqlparser: add drop index "lock | algorithm option" #693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hustjieke hustjieke

Labels
P0 High priority type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hustjieke